src: fix libuv assertion on windows

[liuxingbaoyu]

Set the pointer to nullptr after calling uv_close to avoid assertions.

Fixes: #56645

[juanarbol]

That handle is gonna leak, and I don't think it's gonna fix anything.

This looks pretty much a AI-generated solution... that does actually nothing regarding your intention. 💔

[liuxingbaoyu]

This is not an AI-generated solution, it's an inspiration I got from other code.

node/src/node_platform.cc

Lines 411 to 436 in a8eb690

	void PerIsolatePlatformData::Shutdown() {
	auto foreground_tasks_locked = foreground_tasks_.Lock();
	auto foreground_delayed_tasks_locked = foreground_delayed_tasks_.Lock();
	foreground_delayed_tasks_locked.PopAll();
	foreground_tasks_locked.PopAll();
	scheduled_delayed_tasks_.clear();
	if (flush_tasks_ != nullptr) {
	// Both destroying the scheduled_delayed_tasks_ lists and closing
	// flush_tasks_ handle add tasks to the event loop. We keep a count of all
	// non-closed handles, and when that reaches zero, we inform any shutdown
	// callbacks that the platform is done as far as this Isolate is concerned.
	self_reference_ = shared_from_this();
	uv_close(reinterpret_cast<uv_handle_t*>(flush_tasks_),
	[](uv_handle_t* handle) {
	std::unique_ptr<uv_async_t> flush_tasks{
	reinterpret_cast<uv_async_t*>(handle)};
	PerIsolatePlatformData* platform_data =
	static_cast<PerIsolatePlatformData*>(flush_tasks->data);
	platform_data->DecreaseHandleCount();
	platform_data->self_reference_.reset();
	});
	flush_tasks_ = nullptr;
	}
	}

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00917ba) to head (712964b).
⚠️ Report is 45 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_platform.cc	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61999   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         741      741           
  Lines      242076   242079    +3     
  Branches    45558    45548   -10     
=======================================
+ Hits       218216   218220    +4     
+ Misses      15385    15351   -34     
- Partials     8475     8508   +33     

Files with missing lines	Coverage Δ
src/node_platform.cc	76.00% <66.66%> (-0.25%)	⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[juanarbol]

This is not an AI-generated solution, it's an inspiration I got from other code.

My bad... but sadly still... I don't think this is gonna fix the fundamental problem at all and still leaking.

[liuxingbaoyu]

@juanarbol I understand now. The AI ​​is telling me that the handle wasn't deleted. AI ​​is more familiar with C++ than I am. 🤦‍♂️

[liuxingbaoyu]

Thanks for the reminder!
Sorry, I forgot about that, I'll rebase.

[MikeMcC399]

@juanarbol @addaleax @santigimeno

Would you be able to review this PR again? Changes based on the feedback earlier this year were made.

The original issue #56645 remains currently unfixed. Whether it occurs or not seems to depend on timing and the system it runs on (see nodejs/corepack#715 (comment)).

cc: @nodejs/platform-windows @nodejs/libuv

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75063/

[nodejs-github-bot]

Landed in 0fae62c

[brianrob]

Requesting that this be ported to a v24.x LTS as we're seeing this issue when using v24.16.0.

[MikeMcC399]

Also needed in Node.js 26.x

Corepack CI continues to fail locally in both Node.js 24.19.0 & 26.6.0 - see nodejs/corepack#715