deps: V8: backport 5177b10891e6 - #64631
Closed
avivkeller wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
avivkeller
force-pushed
the
v8-backport-8123081
branch
from
July 20, 2026 16:32
3f332e4 to
2ec3540
Compare
Member
|
CI failure seems related to #64633. |
avivkeller
added
the
commit-queue-rebase
avivkeller
force-pushed
the
v8-backport-8123081
branch
from
July 27, 2026 05:23
2ec3540 to
eb2eb4f
Compare
avivkeller
added
repl
Member
Author
|
cc @nodejs/repl @nodejs/v8 Ready for review, the upstream change has landed |
avivkeller
force-pushed
the
v8-backport-8123081
branch
from
July 27, 2026 05:26
eb2eb4f to
c7fb243
Compare
Member
Author
|
Why didn't git node include the changeset 🤔 I'll re-write it manually. |
avivkeller
changed the title
avivkeller
changed the title
Original commit message:
fix(inspector): hold on to promises
Keep `m_evaluationResult` strong for evaluations
until the promise settles or the request is cancelled.
Bug: 536271637
Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108874}
Refs: v8/v8@5177b10
Co-authored-by: avivkeller <me@aviv.sh>
Signed-off-by: avivkeller <me@aviv.sh>
avivkeller
force-pushed
the
v8-backport-8123081
branch
from
July 27, 2026 05:54
c7fb243 to
1c8abc1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64631 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 744 744
Lines 242518 242518
Branches 45685 45695 +10
==========================================
+ Hits 218611 218638 +27
+ Misses 15396 15389 -7
+ Partials 8511 8491 -20 🚀 New features to boost your workflow:
|
This was referenced Jul 27, 2026
Member
Author
|
Bump @nodejs/v8-update this resolves flaky tests |
daeyeon
approved these changes
Jul 31, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
avivkeller
added
the
author ready
legendecas
approved these changes
Jul 31, 2026
Collaborator
Collaborator
avivkeller
added a commit
that referenced
this pull request
Jul 31, 2026
Original commit message:
fix(inspector): hold on to promises
Keep `m_evaluationResult` strong for evaluations
until the promise settles or the request is cancelled.
Bug: 536271637
Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108874}
Refs: v8/v8@5177b10
Co-authored-by: avivkeller <me@aviv.sh>
PR-URL: #64631
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
avivkeller
added a commit
that referenced
this pull request
Jul 31, 2026
Signed-off-by: avivkeller <me@aviv.sh> PR-URL: #64631 Refs: v8/v8@5177b10 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
Author
|
Landed in b7d29fe...8a1ca0f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@5177b10
Co-authored-by: avivkeller me@aviv.sh