Adding/Deleting authorization and telemetry headers - #351
Merged
Nikitha Chettiar (nikithauc) merged 6 commits intoNov 11, 2020
Conversation
Vincent Biret (baywet)
suggested changes
Nov 10, 2020
Mustafa Zengin (zengin)
suggested changes
Nov 11, 2020
Vincent Biret (baywet)
previously approved these changes
Nov 11, 2020
Member
There was a problem hiding this comment.
besides the comments Mustafa Zengin (@zengin) already added, LGTM. Thanks for making the changes!
Michael Mainer (MIchaelMainer)
left a comment
Michael Mainer (MIchaelMainer)
left a comment
Contributor
There was a problem hiding this comment.
Oops, forgot to submit this yesterday
Mustafa Zengin (zengin)
approved these changes
Nov 11, 2020
Vincent Biret (baywet)
approved these changes
Nov 11, 2020
Michael Mainer (MIchaelMainer)
approved these changes
Nov 11, 2020
Nikitha Chettiar (nikithauc)
deleted the
nikithauc/redirect-drop-customheaders
branch
November 11, 2020 23:45
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265 and #344
Problem 1 - #265 reports a CORs error which was caused because the SDK added telemetry headers only for every request that goes out. The redirected non-Graph endpoint complained about the unexpected SDK_Version header and caused a CORS error.
Solution for Problem 1 - This PR includes logic to check in the
TelemetryHandlerif the URL is a Graph URL and if yes process to add the telemetry headers. If the URL is a non Graph URL and the telemetry headers are present, then the headers are deleted.Problem 2 - #344 Peter Ombwa (@peombwa) Thank you for helping me reproduce this issue!
On redirection, the
RedirectionHandleris currently setting the AuthorizationHeader to undefined instead of completely dropping the header key.The existing code worked fine in a node environment but failed when using ExpressJS.
Solution for Problem 2 - This PR includes change in the
RedirectionHandlerto delete Authorization header key if present.