Checking if the request object url is a graph url - #357
Merged
Nikitha Chettiar (nikithauc) merged 4 commits intoNov 18, 2020
Conversation
Nikitha Chettiar (nikithauc)
requested review from
Michael Mainer (MIchaelMainer) and
Mustafa Zengin (zengin)
November 18, 2020 21:34
Mustafa Zengin (zengin)
previously approved these changes
Nov 18, 2020
Vincent Biret (baywet)
suggested changes
Nov 18, 2020
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Vincent Biret (baywet)
approved these changes
Nov 18, 2020
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for including the suggestion
Mustafa Zengin (zengin)
approved these changes
Nov 18, 2020
Nikitha Chettiar (nikithauc)
deleted the
nikithauc/remove-headers-requestObject
branch
November 18, 2020 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #351, I made changes to add/drop telemetry headers if the request URL is /isn't a Graph URL.
Added one more small change in the
TelemetryHandlerto read the request url from the context.request(which could be a string or a Request object) before checking if the url is a Graph URL or not.