Repository navigation
Add de, the particle of Sri Lankan surnames, to si.toml (strict-gap batch D) - #1033
Merged
Merged
Conversation
…atch D) Sri Lankan names write de before a surname in Latin letters (de Silva, de Mel); strict si broke 334 of its 340 broken records on it. No default or plain-choice parse moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
…ed, recompute, the RFC's dated count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/vocabulary-model.md
# Conflicts: # docs/design/decisions/vocabulary-model.md # docs/release_log.rst # docs/usage.rst # nameparser/_types.py # nameparser/config/_index.py # tests/v2/pipeline/test_assemble.py # tests/v2/test_parser.py
# Conflicts: # docs/design/decisions/vocabulary-model.md # docs/release_log.rst # docs/usage.rst # nameparser/_types.py # nameparser/config/_index.py # tests/v2/pipeline/test_assemble.py # tests/v2/test_parser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strict-gap batch D, decided on 2026-11-03: si.toml takes
de, the particle of Sri Lankan surnames of Portuguese origin (de Silva,de Mel,de Alwis). It is the file's first Latin-script word. The entry copies es.toml's (may_be_given = false).Measured
tools/differential/config_diff.py gapson master f48c88a). Strictsibroke 334 of the language's 340 broken records onde(Sampath Damika De Silva). The 340 fall to 6 on this change alone.simove no cell.si. Strictsi, and strictsi+en, move 28 cells each, every one onto the default's reading. The reviewed table of words strict ungates does not move.Reading.languagesofdegainssiunder the default and every other plain choice (the release log, usage.rst,_types.pyand two tests list it); plainsinamessialone, no role moving.decisions/vocabulary-model gains the batch's entry. The RFC's list of files with no Latin-script vocabulary notes si's change.
Review round
An independent review found no defect. It reproduced 340 → 6, found the default and plain
sireading alike in both trees over 59,321 local names, and read all 330 Sri Lankan ORCID names holdingde: every one is Sinhalese, so ta.toml is owed nothing. Fixed after it:sinamessialone amongde's files.de) and its clause about strictsicorrected.This batch's entry points to batch A's entry (#1030): merge #1030 first.
Checks
uv run pytest -q: 35,787 passed.uv run mypy,uv run ruff check.sphinx-build -b doctestand-W -b html;snapshot.py.-n0 -m serialand Python 3.15.Merge note: #1031 (fil) and #1032 (ca) edit the same list of files for
de. Whichever merges later takes every entry and rebuildsnameparser/config/_index.py.🤖 Generated with Claude Code