Repository navigation
Add the Spanish-derived particles of Filipino surnames to fil.toml (strict-gap batch B) - #1031
Merged
Merged
Conversation
…trict-gap batch B) de, del, san, la and los: strict fil read each as a name word, breaking 473, 94, 70, 46 and 19 records. No default or plain-choice parse moves; under strict fil, del, la and san read as never-given particles (their given readings are es.toml's), which the reviewed ungated table records. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
…oted, recompute, the table's counts dated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/vocabulary-model.md
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strict-gap batch B, decided on 2026-11-03: fil.toml takes
de,del,san,laandlos, the Spanish-derived particles of Filipino surnames (De La Cruz,Del Rosario,San Juan,De Los Santos). It helddelaalone of these, so strictfilread the rest as name words. Each entry copies es.toml's kind and properties;deandlosstatemay_be_given = false, since no file holds a given reading of either.Measured
tools/differential/config_diff.py gapson master f48c88a). Strictfilbroke 473 records onde, 94 ondel, 70 onsan, 46 onlaand 19 onlos(Helbert De La Cruz,Joshua Del Prado,Raul San Diego). With batch A'sjr, the language's 1,066 broken records fall to 28 (simulated with all five batches).filmove no cell.fil. Strictfil, and strictfil+en, move 50 cells each, toward the default's reading, with one class apart:del,laandsanhold agivenreading in es.toml alone. Strictfildrops it and keeps fil's particle reading, so there they read as never-given particles.Del Rosarioreads family 'Del Rosario', where the default reads given 'Del' and reports particle-or-given._reading_index.strict_ungated's reviewed table gainsfil: del, la, san, as it holdsit's for the same three.Reading.languagesofdeandlanow namesfilamong the files, so the release log, usage.rst,_types.pyand two tests list it.decisions/vocabulary-model gains the batch's entry.
Review round
An independent review found no defect. It reproduced every strict-loss figure, and found plain
filreading 0 of 61,947 local names differently. Fixed after it:Santos, Del→ family 'Santos Del' under strictfil, 26 names of a 1-in-4 sample, mostly FEC) and its measured Filipino cost: 2 records (La Reina Eunice Santos,La Trang), none fordelorsan.las(3 Philippine records) is recorded as left out.This batch's entry points to batch A's entry (#1030): merge #1030 first.
Checks
uv run pytest -q: 35,787 passed.uv run mypy,uv run ruff check.sphinx-build -b doctestand-W -b html;snapshot.py.-n0 -m serialand Python 3.15.The batches (A #1030, B, C, D, F) are separate PRs off the same master. Each regenerates
nameparser/config/_index.py, so whichever merges later rebuilds it. This batch's decisions entry points to batch A's umbrella entry, which lands with #1030.🤖 Generated with Claude Code