Repository navigation
Give sultan a given reading in ar.toml (strict-gap batch F) - #1034
Merged
Merged
Conversation
sultan's given and family readings stood in tr.toml alone, so strict ar kept its nobility reading ungated and read the Arabic given name as a title, breaking 226 records. No default or plain-choice parse moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reading, Reading.languages stated, recompute, counts dated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/vocabulary-model.md
# Conflicts: # docs/design/decisions/vocabulary-model.md
# Conflicts: # docs/design/decisions/vocabulary-model.md # tests/v2/test_reading_index.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/design/decisions/vocabulary-model.md
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strict-gap batch F, decided on 2026-11-03: ar.toml gives
sultanagivenreading, the Arabic given name. Itsgivenandfamilyreadings stood in tr.toml alone. So strictarkept ar.toml's nobility reading without its gate (rules/H9's title-only-in-a-phrase), and readSultanas a title. The reading carries tr.toml's Wikidata count of Saudi Arabian bearers.Measured
tools/differential/config_diff.py gapson master f48c88a). Strictarbroke 226 records of Arab countries onsultan(Sultan Sameea, Bahrain); all are recovered (simulated with all five batches).bin; a title; a title phrase), the default and plainarmove no cell.ar. It moves 36 cells and strictar+en33, onto the default's reading, with one exception.Sultan of Omanunder strictaralone needs en.toml'soffor the phrase; withenchosen it reads title 'Sultan of Oman', as the default does._reading_index.strict_ungated's reviewed table dropssultanfromar. It keeps it underms, whose file holds the nobility reading and no name reading.decisions/vocabulary-model gains the batch's entry.
Review round
An independent review found no defect. It reproduced the 226 on this change alone (strict
ar623 broken to 397) and found only strictarmoving over the 2,842 local names holdingsultan. Fixed after it:givenreading carries its own counts, taken 2026-11-03: ORCID's Saudi given boxes 265, the UAE's 32, PatentsView's Saudi 46, nam_dict band 3 in Arabia/Persia. Before, it copied tr.toml's Saudi Wikidata share under tr's date into a field that holds a total.familyreading joins it (ORCID family boxes: Pakistan 141, Iraq 84, Egypt 59, Saudi Arabia 46). It moves no role in the grid, and it namesarinReading.languages.Reading.languagesof a given or familySultangainsar. It names strictms's remaining gap (721 names) and gains a recompute recipe.This batch's entry points to batch A's entry (#1030): merge #1030 first.
Checks
uv run pytest -q: 35,787 passed.uv run mypy,uv run ruff check.sphinx-build -b doctestand-W -b html;snapshot.py.-n0 -m serialand Python 3.15.Merge note: each of the five batch PRs (#1030 to #1033 and this one) regenerates
nameparser/config/_index.py. Whichever merges later rebuilds it (uv run python tools/vocab/build.py).🤖 Generated with Claude Code