Issue 264prefix a parm lists#267
Conversation
* Normalize `callback` and `cb` to `aCb` Not finished yet but shown for @Zren to see what I'm doing Applies to OpenUserJS#264
Applies to OpenUserJS#264 and d7465a3#commitcomment-7004333 > You don't use short forms (cb = callback) with verbose varible name standards. Not explicitly declared the STYLEGUIDE** but can be used to accomodate those who don't know what the short term of a callback is... been debating on making a minimum length too. e.g. not one letter identfiers with a potential prefix.
* At least 1 redundant/unreachable statement found Applies to OpenUserJS#262 Also some uncaught OpenUserJS#255 because no code was executed before... but not doing all of these yet.
…ve libs to do. * Changed "WARNING" on login page to "CAUTION"... a little too assertive... some users may want their email addy in there. * Notated some STYLEGUIDE conformance needs * Notated very short function name(s) * At least one undefined identifier
* Change/Add some more comments in for Ambiguous * Remove some comments added as it appears they have been identified. * Unified what comments I found that I added for 264. Applies to OpenUserJS#264 as well
* Removed one comment Applies to OpenUserJS#264 and inclusive to OpenUserJS#262
|
This getting merged or what? |
|
Yes. I'll merge it today.
|
Issue 264prefix `a` parm lists
|
@sizzlemctwizzle |
It's convoluted because we're using the Passport library in a way that was never intended. It's basically just one giant hack. There's probably a better way to do it, but I'd really have to mess around with it to clean it up. |
Martii
removed
the
needs testing
4 participants
See the plethera of line notes and commit messages.
Applies to #264 and inclusive to #262
Any further changes related to #264 we can catch on the fly I think.
Assigning to sizzle for final testing although others are welcome to test as well.