Throw in strict mode into every part in OUJS#255
Merged
Conversation
* Moved some code around to accomodate this * Fix undefined variables including one from OpenUserJS#246 if this gets merged in first
added 2 commits
July 11, 2014 15:37
Conflicts: controllers/scriptStorage.js Resolved: Use `rLine` for re
Member
Author
|
Re-ready @sizzlemctwizzle. Retested on dev. |
sizzlemctwizzle
added a commit
that referenced
this pull request
Jul 12, 2014
Throw in strict mode into every part in OUJS
Member
Author
|
Checks okay on pro... seems peachy. Thanks. |
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jul 15, 2014
* At least 1 redundant/unreachable statement found Applies to OpenUserJS#262 Also some uncaught OpenUserJS#255 because no code was executed before... but not doing all of these yet.
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Sep 7, 2014
Applies to OpenUserJS#330 and required by OpenUserJS#255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this mode helps us enforce our existing STYLEGUIDE.md not to mention it's cleaner... safer... prevents some common bugs from creeping in... yadda yadda.
Excluded doing anything in
./public/jssince that's not our site code I think... will come back to that if needed... this is also a reason why we shouldn't use it globally except in our own source unless we are maintaining that code. :)Tagging as sooner to expedite because it should be BLOCKING everything else so we don't continually make these mistakes.
Tested on dev all over the place.
Refs: