Some JSHint fixes

[jerone]

Handled code issues:

• Converted all == and != to === and !==.
• Removed unused variables (excluding parameters and isPro, isDev & isDbg).
• Removed unnecessary semicolons.
• Added missing semicolons.
• Fixed some issues where wrong variable names were used.
  • Issue 264prefix a parm lists #267 at 82dc007#diff-590bb4d75f87edbecb61fa8487493291L123
• Renamed already defined variable/function.

Not handled:

• Unused parameter variables.
• Lots of unused variables isPro, isDev & isDbg. +/-90% of the files have one these unused variables…
• User.edit still contains a lot of bugs, but this function is never used.
• Empty code blocks.
• Indentation
• Whitespace

No functionality should have been changed!

Node modules are ignored.

Ref #406

A change to get the code to a higher level of quality and consistency.

[Zren]

This probably fixes a bug. Good find.

[Martii]

@jerone since you have appeared to resolve the ambiguity please remove the line note too associated with this fix. Won't be available until tomorrow eve for a little bit but looks good so far. Thanks.

[Martii]

hmmm direct pr checkout out of this doesn't let me edit my profile at http://localhost:8080/users/Marti e.g. it doesn't think that it's me.

[Martii]

Remaining sequential local merge of current master (50589f1), 451, 455 then 458 causes merge conflict.

[jerone]

@Martii commented on 1 dec. 2014 08:56 CET:

hmmm direct pr checkout out of this doesn't let me edit my profile at http://localhost:8080/users/Marti e.g. it doesn't think that it's me.

Will check tonight. Thnx for testing.

[jerone]

Ok, found the problem: https://github.com/OpenUserJs/OpenUserJS.org/pull/458/files#diff-664f851728e6fc6ec664075df484505cR246
authedUser._id is a string, while user._id is actually an object with among others a method toString(). Also user has the property user.id available, while authedUser doesn't. Both are from the model User.
The problem I think is that user is serialized, because it comes from the session.

This problem is a little bit bigger then I hoped it was and requires some discussion (not here) about a real solution. Because of that I'll revert all authedUser._id === user._id back changes to authedUser._id == user._id.

Some reading:

• http://stackoverflow.com/questions/13104690/nodejs-mongodb-object-id-to-string
• .id returns string while ._id returns object. is this a bug? Automattic/mongoose#548 (comment)

[Martii]

Needs master merge as I said above at #458 (comment) and complete retesting here.

[Martii]

I appear not to "own" my script at http://localhost:8080/scripts/Marti/uso_-_Count_Issues/source e.g. it says "Submit Code as Fork" instead of "Submit Code".

[sizzlemctwizzle]

Leave all equality checks alone. When == or != are used, it was done intentionally. Defer to the programmer's judgement for this instead of blindly following convention and risk breaking things.

[Martii]

I kind of figured that... but I thought I'd give JSHint one last try... I'd still rather see these things split up into smaller chunks... e.g. we do need the semicolon fixes and probably a few other misc TODO fixes... but in separate PRs... I'd do cherry picking distinct commits but that is on hold since it allows chaining changes which sometimes those might need to be discussed first.

Anywho my fakes3 crashed in another console tab which is why I was having issues a few moments ago... reverted that system level patch and it's okay now.

[Martii]

+1 here