Skip to content

fix(signals): classify grpc-node JS/TS protobuf stubs as generated #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimcody1995 wants to merge 1 commit into from
Closed

fix(signals): classify grpc-node JS/TS protobuf stubs as generated #3549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/signals/path-matchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ function isGeneratedFileFrom(parts: NormalizedPath): boolean {
/_pb\.nim$/.test(norm) ||
// Lua protobuf: message stubs are `*_pb.lua`.
/_pb\.lua$/.test(norm) ||
// JavaScript/TypeScript grpc-node protobuf: message stubs are `*_pb.{js,ts}`; gRPC emits
// sibling `*_grpc_pb.{js,ts}` service stubs (underscore form, not `.pb.js`).
/_pb\.(js|ts)$/.test(norm) ||
// Dart codegen: build_runner (`.g.dart`), freezed (`.freezed.dart`), and
// retrofit/injectable (`.gr.dart`) all emit generated part files.
/\.(g|freezed|gr)\.dart$/.test(norm) ||
Expand Down
13 changes: 13 additions & 0 deletions test/unit/path-matchers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,17 @@ describe("isGeneratedFile", () => {
expect(classifyChangedFile("gen/GreeterGrpcKt.kt")).toBe("generated");
});

it("matches JavaScript and TypeScript grpc-node protobuf stubs alongside the other protoc plugins", () => {
expect(isGeneratedFile("gen/service_pb.js")).toBe(true);
expect(isGeneratedFile("gen/service_grpc_pb.js")).toBe(true);
expect(isGeneratedFile("gen/service_pb.ts")).toBe(true);
expect(isGeneratedFile("gen/service_grpc_pb.ts")).toBe(true);
expect(isGeneratedFile("src/app.js")).toBe(false);
expect(isGeneratedFile("src/app.ts")).toBe(false);
expect(classifyChangedFile("gen/service_grpc_pb.js")).toBe("generated");
expect(classifyChangedFile("gen/service_pb.ts")).toBe("generated");
});

it("matches Swift protobuf, Dart freezed/retrofit, C# designer/XAML, and Objective-C protoc output", () => {
for (const path of [
"proto/messages.pb.swift",
Expand Down Expand Up @@ -474,6 +485,8 @@ describe("classifyChangedFile", () => {
["gen/service_pb.nim", "generated"],
["gen/service_pb.lua", "generated"],
["gen/GreeterGrpcKt.kt", "generated"],
["gen/service_grpc_pb.js", "generated"],
["gen/service_pb.ts", "generated"],
["vendor/lib.go", "vendored"],
["package-lock.json", "lockfile"],
["bun.lock", "lockfile"],
Expand Down
Loading