Skip to content

Remove obsolete strict xfail for streaming 3-D reproject (#3100) #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendancol wants to merge 1 commit into from
Closed

Remove obsolete strict xfail for streaming 3-D reproject (#3100) #3180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions xrspatial/tests/test_reproject_streaming_3101.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,20 +166,16 @@ def test_nearest_resampling_with_nan(self):


class TestStreaming3D:
"""3-D sources crash in the streaming assembly (issue #3100)."""
"""3-D sources stream correctly (issue #3100, fixed in #3111)."""

@pytest.mark.xfail(strict=True, raises=ValueError,
reason="2-D output buffer vs 3-D tiles, see #3100")
def test_3d_source_streams(self):
from xrspatial.reproject import reproject
data = np.random.RandomState(5).rand(32, 32, 3)
raster = _make_raster(data)
# max_memory=1 -> serial loop, so the expected failure is the
# deterministic assembly ValueError, never the concurrent
# max_memory=1 -> serial loop, avoiding the concurrent
# parallel-kernel abort from #3141.
out = _run_streaming(raster, tile_size=16, max_memory=1)
# Once #3100 is fixed the xfail comes off and the streaming
# result must match the in-memory 3-D path:
# The streaming result must match the in-memory 3-D path:
ref = reproject(raster, 'EPSG:32633')
assert out.shape == ref.shape
np.testing.assert_allclose(out, ref.values, equal_nan=True)
Loading