Remove obsolete strict xfail for streaming 3-D reproject (#3100)#3180
Closed
brendancol wants to merge 1 commit into
Closed
Remove obsolete strict xfail for streaming 3-D reproject (#3100)#3180brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
Contributor
Author
|
Duplicate of #3181, which merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3118 added
TestStreaming3D::test_3d_source_streamsas a strict xfail for #3100, but #3111 (which fixes the 2-D output buffer crash by carrying the band axis through both assembly branches) landed after #3118's CI ran. The test now XPASSes, which strict mode reports as a failure, so every pytest run on main is red, along with any PR branched from it (e.g. #3119).This removes the xfail marker and updates the comments. The test runs as a plain regression test now; the file passes 15/15 locally.
Closes #3100.