Skip to content

test: use Vite+ preview for CLI subprocesses #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengmk2 wants to merge 1 commit into from
Closed

test: use Vite+ preview for CLI subprocesses #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ jobs:
}

- uses: voidzero-dev/setup-vp@2dec1e33f4ab2c6d5bce1b0c4607961bb1a3f7a1 # v1.12.0
env:
VP_PR_VERSION: 0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
with:
version: 0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
node-version-file: .node-version
cache: true

Expand Down Expand Up @@ -100,7 +103,10 @@ jobs:
with:
persist-credentials: false
- uses: voidzero-dev/setup-vp@2dec1e33f4ab2c6d5bce1b0c4607961bb1a3f7a1 # v1.12.0
env:
VP_PR_VERSION: 0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
with:
version: 0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
node-version-file: .node-version
cache: true
# Fail closed BEFORE the build: a missing/empty credential must fail this job, not self-skip. The
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ jobs:

- run: npm install -g npm@11
- run: vp pm publish -r --access public --tag latest --no-git-checks
env:
NPM_CONFIG_REGISTRY: https://registry.npmjs.org
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
@void-sdk:registry=https://npm.pkg.github.com
# Resolve the pinned Vite+ preview from the registry bridge.
registry=https://registry-bridge.viteplus.dev/
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ Full docs at [void.cloud](https://void.cloud). Run `vp run dev:docs` in this rep

### Setup

This branch uses Vite+ preview commit `0e24d6c`. Install the matching CLI from the
[preview build instructions](https://github.com/voidzero-dev/vite-plus/pull/2665#issuecomment-5629721393)
before running the setup commands below.

```sh
git clone https://github.com/nicepkg/void.git
cd void
Expand Down
2 changes: 1 addition & 1 deletion packages/void/test/integration/cli-help.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function createProject(): string {
}

function runVoid(root: string, args: Array<string>): { output: string; status: number } {
const res = spawnSync(process.execPath, [CLI_ENTRY, ...args], {
const res = spawnSync('node', [CLI_ENTRY, ...args], {
cwd: root,
encoding: 'utf8',
env: {
Expand Down
2 changes: 1 addition & 1 deletion packages/void/test/integration/env-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function runVoid(
root: string,
args: Array<string>,
): { stdout: string; stderr: string; status: number } {
const res = spawnSync(process.execPath, [CLI_ENTRY, ...args], {
const res = spawnSync('node', [CLI_ENTRY, ...args], {
cwd: root,
encoding: 'utf8',
// Isolate: the env command shouldn't pick up the developer's real env.
Expand Down
2 changes: 1 addition & 1 deletion packages/void/test/integration/prepare-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function runVoid(
root: string,
args: Array<string>,
): { stdout: string; stderr: string; status: number } {
const res = spawnSync(process.execPath, [CLI_ENTRY, ...args], {
const res = spawnSync('node', [CLI_ENTRY, ...args], {
cwd: root,
encoding: 'utf8',
env: {
Expand Down
4,618 changes: 2,309 additions & 2,309 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 14 additions & 2 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ catalog:
typescript: 7.0.2
'@voidzero-dev/vitepress-theme': ^5.0.7
pathslash: ^0.1.0
vite: npm:@voidzero-dev/vite-plus-core@0.3.1
vite-plus: 0.3.1
vite: npm:@voidzero-dev/vite-plus-core@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
vite-plus: 0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a
wrangler: 4.107.0

catalogs:
Expand All @@ -51,3 +51,15 @@ peerDependencyRules:
allowedVersions:
tailwindcss: '*'
vite: '*'

minimumReleaseAgeExclude:
- '@voidzero-dev/vite-plus-core@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-darwin-arm64@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-darwin-x64@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-linux-arm64-gnu@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-linux-arm64-musl@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-linux-x64-gnu@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-linux-x64-musl@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-win32-arm64-msvc@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- '@voidzero-dev/vite-plus-win32-x64-msvc@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a'
- vite-plus@0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4a