Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin
vite-plusand thevitealias to preview build0.0.0-commit.0e24d6c2139ea8733ee4a1dd70e4a2a1ba8b4a4afrom vite-plus#2665. CI uses the same CLI build, and the registry bridge supplies the preview packages.Restore
spawnSync('node', ...)in the three CLI integration suites to test Node resolution throughPATH. Keep the temporary home directories for test isolation.The package build, package typechecks, and all 16 CLI integration tests pass. The React browser suite fails two
useIdhydration tests, in dev and preview modes.