Repository navigation
refactor: effect/avoid-untagged-errors to zero - #610
Merged
Merged
Conversation
Part of #533. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5G6PMempKsgjiV1NDcCJY
🦋 Changeset detectedLatest commit: b71426d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #533.
effect/avoid-untagged-errorsgoes from 62 sites to 0 and itswarnline is deleted fromvite.config.ts; the inlineoxlint-disable-next-lineinsrc/Query.tsis gone because that site is fixed.src/(Resource, Include, Relationship, Query, Endpoint, Handlers, Lid, Registry, ApiError,internal/operators,internal/schemaExt) still throw synchronously at the same moment with the same message text. They now throw an internalDeclarationError, a brandedSchema.TaggedErrorin the newsrc/internal/errors.ts, built throughdeclarationError(message). It is not exported, so no new public API.Query.tsmessageOfand the blog example usePredicate.isErrorinstead ofinstanceof Error.InvalidOperation.assert(...)fromvite-plus/test. Stand-in causes become a per-file brandedBoomtagged error.test/entry-points.test.tslistsinternal/errors.tsin the schema tier (it imports onlyeffect/Schema).Site counts:
effect/avoid-untagged-errors62 -> 0. Totalvp lintdiagnostics 4055 -> 3993, with no other rule's count up (every other rule unchanged).Verification
pnpm install --frozen-lockfile: passvp run build: passvp check: passvp run check: passvp run -r test:unit: passvp run docgen: passvp run test:coverage: pass;vp exec fallow audit --base origin/trunk: verdict passChangeset
.changeset/declaration-error.md(patch): thrown declaration errors keep their messages andinstanceof Error, but are nowDeclarationErrorwithname/_tag"DeclarationError"instead of a bareError. No class is exported.Notes
No exported signatures or declaration-emit shape change. Runtime-visible only through the thrown value's
name/_tag.Generated by Claude Code