Repository navigation
test: effect-run-in-body to zero in examples/, and flip the rule to error - #607
Merged
Merged
Conversation
|
thomasfosterau
force-pushed
the
issue-600-examples
branch
from
November 12, 2026 05:16
2f90bf8 to
860da60
Compare
Move the examples' Effect-running tests to it.effect and run the conformance suites' one shared report through layer(...) rather than a top-level await. Add @effect/vitest to each example's devDependencies and delete the rule's warn line in vite.config.ts, so effect-run-in-body is at error with zero sites. Part of #600. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5G6PMempKsgjiV1NDcCJY
thomasfosterau
force-pushed
the
issue-600-examples
branch
from
November 12, 2026 05:25
860da60 to
be5e1fa
Compare
Keep the it.effect structure of the example suites and re-apply trunk's imperative-loop conversions (Arr.forEach) inside it; take trunk's lockfile and re-resolve. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5G6PMempKsgjiV1NDcCJY
…579 moved it to .claude/) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5G6PMempKsgjiV1NDcCJY
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #600. Stacked on #606: this branch is rebased on
issue-600-effect-run-in-body, so until #606 merges the diff also shows its commit; review only2f90bf8. After #606 merges I will rebase ontotrunk.Converts the last 20
effect/effect-run-in-bodysites, all inexamples/(blog, github, northwind), and deletes the rule'swarnline invite.config.ts, so the rule is aterrorwith zero sites.@effect/vitest: "catalog:"added to each example'sdevDependencies;pnpm-lock.yamlupdated.blog.test.ts,atomic.test.ts,client.test.ts,github.test.ts,northwind.test.ts:run/runExithelpers return Effects; tests areit.effect.conformance.test.tsfiles built one report with a top-levelawait Effect.runPromise(...)shared by every test. That is now aRunservice built once byLayer.effectand provided withlayer(RunLive)(...)from@effect/vitest; each test reads it withyield* Run. The conformance run itself (including the mutating write rules) still happens exactly once per file.Schema.decodeUnknownSyncinsideEffect.genbecameyield* Schema.decodeUnknownEffect, andEffect.genwhose only statement wasyield* run(...)returnsrun(...)directly.Lint deltas against trunk plus #606 (rule counts):
effect/effect-run-in-body20 to 0; no other rule changed. Test counts per file are unchanged (blog 73, github 56, northwind 50).effecttsgo/strict-effect-provideis untouched, as agreed.Verification
origin/trunkmerged into the branch (merge commit8585124, no rebase) to pick up #613 (imperative loops), #610 (untagged errors), #608 (effect and@effect/vitestat 4.1.4) and #582. The six example test files conflicted; each keeps this PR'sit.effectstructure with #613'sfortoArr.forEachconversions re-applied inside it.pnpm-lock.yamlis trunk's, re-resolved withpnpm install:@effect/vitestandeffectare at 4.1.4 with no 4.1.2 entries for either.GOMAXPROCS=2 GOMEMLIMIT=3GiB:pnpm install --frozen-lockfile: passvp run build: passvp check: pass (0 errors)vp run --concurrency-limit 1 check: pass ("check: every type gate green")vp run -r test:unit: pass (4010 + 56 + 50 + 73)vp run docgen: passvp run test:coverage: pass, thenvp exec fallow audit --base origin/trunk: exit 0 (11 complexity findings above threshold and 19 duplication clone groups, warn-only; the gate excluded 29 inherited findings)Changeset
None: tests, devDependencies of private example packages and lint config only; the published package is unchanged.
Notes
The
describein the conformance files becamelayer(RunLive)(name, (it) => ...), soitthere is the layer-scoped runner;vitest/no-standalone-expectalready knowsit.effect.Generated by Claude Code