Repository navigation
trace: Move FW description log location - #3319
Conversation
This log should be added just after buffer initialization, to make it the first one in the output file - for easy identyfication. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Then src hash and ldc hash should have the same format. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
|
|
||
| /* flush fw description message */ | ||
| trace_flush(); | ||
|
|
There was a problem hiding this comment.
@ktrzcinx Why, with this change, tr_info and trace_flush() are no longer close one to each other?
There was a problem hiding this comment.
To flush after dma_trace_start - possible part of trace initialization while writing trace log just after buffer initialization (after moving it one line below then it's not the first trace log)
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Can we make this tr_err() so that this message also hits the error log ? The inline comment can explain why it's using tr_err().
|
Are we sure changing it to |
|
@ktrzcinx it may do, but CI folks are asking for a check for erro log. @zrombel @xiulipan @aiChaoSONG any commens, this PR could add an initial "hello world" message in th eerror log to show CI it's working (message is NOT an error). |
|
Not an issue for Quickbuild CI. |
|
@ktrzcinx It would be OK for Jenkins CI. We are trying to modify our test scripts to check a "hello world" message to make sure trace function is working. |
Use tr_err to have this initial message also in error logs and assert traces works well. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
dcf2d5a to
c6ed90f
Compare
|
SOFCI TEST |
|
Known Jenkins CI issues. |
This log should be added just after buffer initialization,
to make it the first one in the output file - for easy identyfication.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com