Skip to content

[FEATURE]Add an error trace message for functionality check  #3281

Closed

Description

@xiulipan

Is your feature request related to a problem? Please describe.
Add a message like Hello SOF into error trace to show error trace works

Describe the solution you'd like

  • create new component to show this messge
  • Add this into one existing component

Additional context
Discussion moved from #3265

Activity

  1. xiulipan commented on Aug 7, 2020

    @xiulipan
    ContributorAuthor

    @plbossart @lgirdwood @lyakh @paulstelian97 @marc-hb moved the discussion in #3265 here.
    We have 2 proposal:

    • create new component to show this message (need to send the message after trace init)
    • Add this into one existing component (eg. Add this message in IPC comp, but may show multiple time)

    Please have some comments. Then we can refine out logger check test case to track error trace status.

  2. paulstelian97 commented on Aug 7, 2020

    @paulstelian97
    Collaborator

    I think the message could be shown in either the generic SOF init code or in the platform init code. I suggested IPC only because messages have to be tied to some component.

    Or perhaps trace init itself could show a message (configurable, of course) or just dump the message into the mailbox as some sort of initialization.

  3. xiulipan commented on Aug 7, 2020

    @xiulipan
    ContributorAuthor

    @paulstelian97 I tried to add this kind for message into trace init. It used to be very easy in past if we just send trace message into mailbox. But now the trace in mailbox is actually some address and date, then we need a ldc file to parse it out.

    I will have try and RFC PRs

  4. paulstelian97 commented on Aug 7, 2020

    @paulstelian97
    Collaborator

    We don't need ldc file to verify that there is some message, only to actually decode it. You can put in some fixed parameters in the message and the parameters don't need the LDC file to check, if you know how many there should be beforehand.

  5. lyakh commented on Aug 7, 2020

    @lyakh
    Collaborator

    @plbossart @lgirdwood @lyakh @paulstelian97 @marc-hb moved the discussion in #3265 here.
    We have 2 proposal:

    * create new component to show this message (need to send the message after trace init)
    
    * Add this into one existing component (eg. Add this message in IPC comp, but may show multiple time)
    

    Please have some comments. Then we can refine out logger check test case to track error trace status.

    Use &sa_tr from agent.c?

  6. lgirdwood commented on Aug 7, 2020

    @lgirdwood
    Member

    @xiulipan keep it simple. Just emit trace error level in platform_boot() for each platform.

  7. marc-hb commented on Apr 27, 2021

    @marc-hb
    Collaborator

    Was this fixed by commit 67a0a69 / PR #3319?

  8. marc-hb commented on Apr 28, 2021

    @marc-hb
    Collaborator

    Assuming fixed and closing, re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions