You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[FEATURE]Add an error trace message for functionality check #3281
I think the message could be shown in either the generic SOF init code or in the platform init code. I suggested IPC only because messages have to be tied to some component.
Or perhaps trace init itself could show a message (configurable, of course) or just dump the message into the mailbox as some sort of initialization.
@paulstelian97 I tried to add this kind for message into trace init. It used to be very easy in past if we just send trace message into mailbox. But now the trace in mailbox is actually some address and date, then we need a ldc file to parse it out.
We don't need ldc file to verify that there is some message, only to actually decode it. You can put in some fixed parameters in the message and the parameters don't need the LDC file to check, if you know how many there should be beforehand.
* create new component to show this message (need to send the message after trace init)
* Add this into one existing component (eg. Add this message in IPC comp, but may show multiple time)
Please have some comments. Then we can refine out logger check test case to track error trace status.
Activity
xiulipan commentedon Aug 7, 2020
@plbossart @lgirdwood @lyakh @paulstelian97 @marc-hb moved the discussion in #3265 here.
We have 2 proposal:
Please have some comments. Then we can refine out logger check test case to track error trace status.
paulstelian97 commentedon Aug 7, 2020
I think the message could be shown in either the generic SOF init code or in the platform init code. I suggested IPC only because messages have to be tied to some component.
Or perhaps trace init itself could show a message (configurable, of course) or just dump the message into the mailbox as some sort of initialization.
xiulipan commentedon Aug 7, 2020
@paulstelian97 I tried to add this kind for message into trace init. It used to be very easy in past if we just send trace message into mailbox. But now the trace in mailbox is actually some address and date, then we need a ldc file to parse it out.
I will have try and RFC PRs
paulstelian97 commentedon Aug 7, 2020
We don't need ldc file to verify that there is some message, only to actually decode it. You can put in some fixed parameters in the message and the parameters don't need the LDC file to check, if you know how many there should be beforehand.
lyakh commentedon Aug 7, 2020
Use
&sa_trfrom agent.c?lgirdwood commentedon Aug 7, 2020
@xiulipan keep it simple. Just emit trace error level in platform_boot() for each platform.
marc-hb commentedon Apr 27, 2021
Was this fixed by commit 67a0a69 / PR #3319?
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
marc-hb commentedon Apr 28, 2021
Assuming fixed and closing, re-open if needed.
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs
check-sof-logger: rewrite most of it so it can actually find bugs