Skip to content

remove plughw in alsabat test - #554

Merged
aiChaoSONG merged 1 commit into
thesofproject:masterfrom
keqiaozhang:remove_plug
Jan 11, 2021
Merged

aiChaoSONG merged 1 commit into
thesofproject:masterfrom
keqiaozhang:remove_plug

Conversation

@keqiaozhang

Copy link
Copy Markdown
Contributor

Add channel and rate options support in alsabat test and
remove use of plughw to run alsabat test at hw level w/o
any conversions done by alsa-lib.

Signed-off-by: Zhang Keqiao keqiao.zhang@linux.intel.com

@marc-hb

marc-hb commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator

Sorry I don't understand why the number of channels is hardcoded for playback but not for capture.

I also find the code comment not visible enough, I think a dlogw or at the very least a dlogi warning should be printed.

@keqiaozhang

Copy link
Copy Markdown
Contributor Author

Sorry I don't understand why the number of channels is hardcoded for playback but not for capture.

I also find the code comment not visible enough, I think a dlogw or at the very least a dlogi warning should be printed.

This script is for sof playback test, as our sof doesn't support 1 channel(mono wav) playback, so I set the channel number to 2.

Since we use different USB sound cards in CI, old USB sound cards only support 1 channel capture and new USB sound cards support 2 channels, so I set the channel number of capture as an option( -C ), we can specify it in the alsabat-playback.csv file for each platform.
We plan to buy more USB sound cards to replace the old one in CI. After that, we can remove this option and test 2 channels for both playback and capture.

aiChaoSONG
aiChaoSONG previously approved these changes Jan 11, 2021

@aiChaoSONG aiChaoSONG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some usb card now support stereo channel, thanks for the fix.

@xiulipan

Copy link
Copy Markdown
Contributor

@keqiaozhang Need to take care nocodec platforms, they do not use USB loopback.

xiulipan
xiulipan previously approved these changes Jan 11, 2021
@aiChaoSONG

Copy link
Copy Markdown

SOFCI TEST

Add channel and rate options support in alsabat test and
remove use of plughw to run alsabat test at hw level w/o
any conversions done by alsa-lib.

Signed-off-by: Zhang Keqiao <keqiao.zhang@linux.intel.com>
@aiChaoSONG

Copy link
Copy Markdown

The failure on APL_NOCODEC is not caused by this PR, but need to fine tune.

@aiChaoSONG
aiChaoSONG merged commit 0bbd217 into thesofproject:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants