Skip to content

check-alsabat.sh: remove use of plughw #241

Description

@plbossart

We want to play and record directly at the hw level, not with any conversions done by alsa-lib.
This is wrong and needs to be fixed, it will hide issues or mask conversions.

Activity

  1. aiChaoSONG commented on Sep 2, 2020

    @aiChaoSONG

    @keqiaozhang I think the plughw in alsabat playback is required, because the USB card cannot support all formats and sample rates, but do you think we can remove plughw from alsabat capture?

  2. plbossart commented on Sep 2, 2020

    @plbossart
    MemberAuthor

    sorry I don't get the point @aiChaoSONG.

    What I meant was that all access to the SOF device should be with hw:

  3. keqiaozhang commented on Sep 3, 2020

    @keqiaozhang
    Contributor

    @plbossart , I agree with you, adding plughw is not a wise choice. The reason we use plughw is that the USB sound card only support 1 channel capture and for nocodec mode, we don't use USB sound card for capture, we use the passthrough pipeline directly and it supports 2 channels capture. To unify the channel count, we decided to use this workaround.
    I believe there're still have some other reasons, but I can't record right now.
    @xiulipan , please help to add here if you still remember.
    I will try to refine the test script for alsabat test next.

  4. xiulipan commented on Sep 24, 2020

    @xiulipan
    Contributor

    @plbossart The plughw here is used because we do not use pulseaudio and we do not know what fmt/channel/rate is supported for our loopback (playback/captur) PCM. So remove plughw is not a option for alsabat test.

  5. keqiaozhang commented on Sep 24, 2020

    @keqiaozhang
    Contributor

    I have submitted a PR #401 to remove plughw for alsabat test. we can use tplgreader to get the fmt/channel and rate for playback PCM, but for USB sound card(used to capture the loopback data), it only support S16_LE/1 channel, so I just specified format and channel for USB sound card.

  6. xiulipan commented on Sep 24, 2020

    @xiulipan
    Contributor

    @keqiaozhang We also have headset capture test, you can only removed plug from one side.

  7. added
    type:bugSomething doesn't work as expected
    state:ping-for-closeWill be closed if submitter is not responsive
    and removed
    state:wontfixThis will not be worked on
    on Jan 26, 2021
  8. xiulipan commented on Jan 26, 2021

    @xiulipan
    Contributor

    merged #554 @keqiaozhang @plbossart can we close this issue.

  9. keqiaozhang commented on Mar 29, 2021

    @keqiaozhang
    Contributor

    PR#554 is merged, this issue can be closed.

  10. added and removed
    state:ping-for-closeWill be closed if submitter is not responsive
    on Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething doesn't work as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions