Skip to content

hijack.sh: don't fail yet when sof-logger resists kill -INT - #381

Merged
xiulipan merged 1 commit into
thesofproject:masterfrom
marc-hb:logger-resist
Sep 18, 2020
Merged

xiulipan merged 1 commit into
thesofproject:masterfrom
marc-hb:logger-resist

Conversation

@marc-hb

@marc-hb marc-hb commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator

Mitigates #3433 for now.

Signed-off-by: Marc Herbert marc.herbert@intel.com

Mitigates #3433 for now.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>

@aiChaoSONG aiChaoSONG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Marc, Let's wait for the CI test result.

@xiulipan
xiulipan marked this pull request as ready for review September 18, 2020 02:35
@xiulipan
xiulipan requested a review from a team as a code owner September 18, 2020 02:35
@xiulipan
xiulipan merged commit a2669ff into thesofproject:master Sep 18, 2020
@xiulipan

Copy link
Copy Markdown
Contributor

@marc-hb I merged the workaround now. Do we need to check why the logger resist -INT

@marc-hb

marc-hb commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator Author

This has been broken for almost 24h, we could have waited a few more minutes for https://sof-ci.01.org/softestpr/PR381/build192/devicetest to complete. I hope we won't need another quick workaround on top of this other workaround that would be messy.

Do we need to check why the logger resist -INT

I think so and I filed https://github.com/thesofproject/sof/issues/3433 for that.

@marc-hb
marc-hb deleted the logger-resist branch September 18, 2020 02:42
@marc-hb

marc-hb commented Sep 18, 2020 •

Copy link
Copy Markdown
Collaborator Author

we could have waited a few more minutes

@xiulipan peeked at the logs before everything was finished and the results uploaded to https://sof-ci.01.org/softestpr/PR381/build192/devicetest. They are uploaded now and the vast majority of tests are passing.

To be continued in https://github.com/thesofproject/sof/issues/3433

@xiulipan

Copy link
Copy Markdown
Contributor

@marc-hb Checked the running logs, so I think this fix works.
Thanks for the issue reported, the issue is wired. I did not see this issue in previous test. Try to manually check the issue.

@marc-hb

marc-hb commented Sep 18, 2020 •

Copy link
Copy Markdown
Collaborator Author

@marc-hb marc-hb added the area:logs Log and results collection, storage, etc. label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logs Log and results collection, storage, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants