Skip to content

[BUG] sof-logger resisted pkill -INT, using -KILL #385

Closed
Closed
[BUG] sof-logger resisted pkill -INT, using -KILL#385
Assignees
xiulipanaiChaoSONG
Labels
False Pass / green failureP2Critical bugs or normal featuresarea:logsLog and results collection, storage, etc.type:bugSomething doesn't work as expected

Description

@marc-hb
marc-hb
opened on Sep 18, 2020

#373 was merged because https://sof-ci.01.org/softestpr/PR373/build182/devicetest was all green. However almost all tests were failing because the sof-logger resisted kill -INT. To make it worse I misused exit_status=2 which has the special meaning Not Applicable which means no error and everything is green.

Activity

  1. marc-hb commented on Sep 18, 2020

    @marc-hb
    marc-hb
    on Sep 18, 2020
    CollaboratorAuthor

    Quick workaround submitted at #381

  2. marc-hb
    self-assigned this
    on Sep 18, 2020
  3. marc-hb
    added a commit that references this issue on Sep 18, 2020

    hijack.sh: switch first attempt to stop the logger from -INT to -TERM

    6e5def7

  4. marc-hb commented on Sep 18, 2020

    @marc-hb
    marc-hb
    on Sep 18, 2020
    CollaboratorAuthor

    I cannot reproduce locally but I got an idea:

    2020-09-17 20:56:25 UTC [REMOTE_ERROR] sof-logger resisted pkill -INT, using -KILL

    I don't do anything REMOTE_ maybe that's why it's happening in CI and not locally.

    From https://pubs.opengroup.org/onlinepubs/7908799/xsh/signal.h.html

    SIGINT | i | Terminal interrupt signal.

    I've never done the REMOTE_ thing, no idea how to do it. @xiulipan or @aiChaoSONG could you compare REMOTE_ vs local for me?

  5. marc-hb commented on Sep 18, 2020

    @marc-hb
    marc-hb
    on Sep 18, 2020
    CollaboratorAuthor

    I switched from -INT to -TERM and it works, please review: #382

    I filed this in sof because I was afraid it was an issue with the logger but now I think it's just an sof-test issue.

  6. marc-hb
    assigned
    xiulipan
    and
    aiChaoSONG
    and unassigned
    marc-hb
    on Sep 18, 2020
  7. marc-hb
    transferred this issue fromthesofproject/sofon Sep 18, 2020

  8. mengdonglin commented on Sep 28, 2020

    @mengdonglin
    mengdonglin
    on Sep 28, 2020
    Contributor

    Keep this issue open before we root cause if this is a bug of sof-logger or test case.

    • If this is an sof-logger issue, will close this issue and report a bug in SOF repo.
    • If this is a test case issue, we will use PR refine alsabat test script #401 and close this issue.
  9. mengdonglin
    added
    type:bugSomething doesn't work as expected
    P2Critical bugs or normal features
    on Sep 28, 2020

  10. marc-hb commented on Sep 28, 2020

    @marc-hb
    marc-hb
    on Sep 28, 2020
    CollaboratorAuthor

    I believe this has been fixed by #382 hijack.sh: switch first attempt to stop the logger from -INT to -TERM, closing.

  11. mengdonglin
    closed this as completedon Oct 19, 2020
  12. marc-hb
    added
    area:logsLog and results collection, storage, etc.
    False Pass / green failure
    on Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

False Pass / green failureP2Critical bugs or normal featuresarea:logsLog and results collection, storage, etc.type:bugSomething doesn't work as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions