Repository navigation
Conversation
Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_license_headers
status: passed
---
Apply the review suggestions from stdlib-js#12713.
2 of 7 tasks
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #12713.
Description
This pull request:
@stdlib/stats/base/ttest/alternatives. This is @bhargava-d16's work from feat: addstats/base/ttest/alternatives#12713, with their commits kept as they are.stats/base/ttest/alternatives#12713: spaces inside the parentheses inlib/index.jsandtest/test.js, copied fromstats/base/ztest/alternatives.package.json.Related Issues
This pull request has the following related issues:
stats/base/ttest/alternatives#12713Reference Packages
This pull request followed these packages:
stats/base/ztest/alternativesstats/base/ttest/alternatives#12713 unchanged.Questions
No.
Other
I asked on #12713 on Nov 18 whether @bhargava-d16 planned to address the review and said I'd open a follow-up if there was no reply by Nov 21. If they'd rather finish #12713 themselves, I'm happy to close this.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used Claude Code to apply the review's formatting fixes and to compare the test file with
stats/base/ztest/alternatives. I reviewed every changed line myself.@stdlib-js/reviewers