Repository navigation
feat: add stats/base/ttest/alternatives - #12713
bhargava-d16 wants to merge 2 commits into
Conversation
Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/ttest/alternatives
|
|
||
| // MAIN // | ||
|
|
||
| setReadOnly(main, 'enum', enumeration); |
There was a problem hiding this comment.
Spaces inside the parens, per our style guide and the stats/base/ztest/alternatives reference.
| setReadOnly(main, 'enum', enumeration); | |
| setReadOnly( main, 'enum', enumeration ); |
|
|
||
| // TESTS // | ||
|
|
||
| tape('main export is a function', function test(t) { |
There was a problem hiding this comment.
This whole file is missing the inner-paren spacing we require (tape( '...', function test( t ) {, t.ok( true, __filename );, obj[ o[ i ] ], etc.). Copy the formatting verbatim from stats/base/ztest/alternatives/test/test.js.
|
Hi @bhargava-d16, Athan confirmed on Zulip (#179 thread) that the t-tests should have their own alternatives package, so this PR is needed for the t-test work. Are you planning to address Philipp's two spacing comments? If I don't hear back by Saturday (Nov 21), I'll open a new PR that keeps your commit and applies the fixes, with credit to you. |
|
I've opened #16743 with Philipp's two spacing fixes on top of your commits, so the t-test work can move forward. @bhargava-d16, if you'd rather finish this PR yourself, just say so and I'll close mine. |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None.
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers