Skip to content

gh-117873: Deprecate grp keyword arguments #118010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

gh-117873: Deprecate grp keyword arguments #118010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ Optimizations
Deprecated
==========

* :mod:`grp`: Deprecate passing keyword arguments to :func:`grp.getgrgid` and
:func:`grp.getgrnam` functions.
(Contributed by Victor Stinner in :gh:`117873`.)


Removed
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-04-17-23-14-05.gh-issue-117873.3cf35E.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:mod:`grp`: Deprecate passing keyword arguments to :func:`grp.getgrgid` and
:func:`grp.getgrnam` functions. Patch by Victor Stinner.
42 changes: 41 additions & 1 deletion Modules/clinic/grpmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions Modules/grpmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ mkgrent(PyObject *module, struct group *p)
grp.getgrgid

id: object
/ [from 3.16]

Return the group database entry for the given numeric group ID.

Expand All @@ -122,7 +123,7 @@ If id is not valid, raise KeyError.

static PyObject *
grp_getgrgid_impl(PyObject *module, PyObject *id)
/*[clinic end generated code: output=30797c289504a1ba input=15fa0e2ccf5cda25]*/
/*[clinic end generated code: output=30797c289504a1ba input=b0f482517fa9c22a]*/
{
PyObject *retval = NULL;
int nomem = 0;
Expand Down Expand Up @@ -194,6 +195,7 @@ grp_getgrgid_impl(PyObject *module, PyObject *id)
grp.getgrnam

name: unicode
/ [from 3.16]

Return the group database entry for the given group name.

Expand All @@ -202,7 +204,7 @@ If name is not valid, raise KeyError.

static PyObject *
grp_getgrnam_impl(PyObject *module, PyObject *name)
/*[clinic end generated code: output=67905086f403c21c input=08ded29affa3c863]*/
/*[clinic end generated code: output=67905086f403c21c input=bbcdbc9a8786c117]*/
{
char *buf = NULL, *buf2 = NULL, *name_chars;
int nomem = 0;
Expand Down