gh-117873: Deprecate grp keyword arguments - #118010
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Member
Author
|
I convert this PR to a draft until the main branch becomes Python 3.14. |
vstinner
marked this pull request as ready for review
May 8, 2024 16:27
vstinner
marked this pull request as draft
May 8, 2024 16:34
Contributor
|
Do we need to change the deprecation version to 3.16 now? And does it need to be in the 3.14 news file? |
Member
Author
Done, I rebased my PR on the main branch which is now Python 3.14. |
vstinner
marked this pull request as ready for review
May 10, 2024 09:15
Member
Author
|
@erlend-aasland @corona10: Do you want to review this change? |
Member
|
Not now but at Pittsburgh |
corona10
reviewed
May 18, 2024
Member
|
If yes, I am not sure that it is a good approach since we require the user to change their use case to optimize our implementation. For me, this is a better approach
|
Member
Author
|
Ok, I close my PR. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
METH_VARARGSin clinic code #117873📚 Documentation preview 📚: https://cpython-previews--118010.org.readthedocs.build/