Repository navigation
gh-103987: fix crash in mmap module - #103990
Conversation
|
I am closing the mmap object, still the test is failing |
|
Let's wait CI/CD results. Also, can you add a few lines about this in |
|
Great work @Agent-Hellboy ! |
|
still some cases not covered properly. Now that you moved the also you should add a test that uses the weird and you need to do the same thing again for assignment, both with or something like that. Also there needs to be a test for the special case I mentioned at the end of the issue: |
|
hi @cfbolz, Now I am checking at the start as well which denies throwing TypeError for closed mmap |
|
now you need to do the same things for item assignments still. |
|
We should |
|
I am saying you should add these |
|
Hi @sunmy2019, please share with me a scenario where it's bypassing the first |
|
|
Currently, it's throwing expected Value error, i have added a test for the same |
This is wrong. And you are not creating a new |
…python into fix-issue-103987
I think checking |
…RgALL.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
I think it's now ready for review. @JelleZijlstra @cfbolz Sorry for the delay! |
|
|
||
| if (result_buf == NULL) | ||
| return PyErr_NoMemory(); | ||
|
|
There was a problem hiding this comment.
Could the buffer have been invalidated here as a side effect of the PyMem_Malloc call above triggering GC? I seem to recall that's possible, but not 100% sure.
There was a problem hiding this comment.
I cannot find any GC-related code in Object/obmalloc.c
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Thanks @Agent-Hellboy for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-104677 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit ceaa4c3) Co-authored-by: Prince Roshan <princekrroshan01@gmail.com> Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
* main: (30 commits) pythongh-103987: fix several crashes in mmap module (python#103990) docs: fix wrong indentation causing rendering error in dis page (python#104661) pythongh-94906: Support multiple steps in math.nextafter (python#103881) pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667) pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842) pythongh-85984: New additions and improvements to the tty library. (python#101832) pythongh-104659: Consolidate python examples in enum documentation (python#104665) pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678) pythongh-104645: fix error handling in marshal tests (python#104646) pythongh-104600: Make type.__type_params__ writable (python#104634) pythongh-104602: Add additional test for listcomp with lambda (python#104639) pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641) pythongh-103921: Rename "type" header in argparse docs (python#104654) Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649) pythongh-96522: Fix deadlock in pty.spawn (python#96639) pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline. (pythonGH-104579) pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606) pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624) pythongh-104619: never leak comprehension locals to outer locals() (python#104637) pythongh-104602: ensure all cellvars are known up front (python#104603) ...
Uh oh!
There was an error while loading. Please reload this page.