Repository navigation
Correct Chinese quadrillion translations - #473
Open
Plastic-time wants to merge 1 commit into
Open
Plastic-time wants to merge 1 commit into
Plastic-time wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 12 12
Lines 1020 1020
=======================================
Hits 1017 1017
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
zh_CNactive,intword(10**15)currently returns1.0 万亿;zh_HKreturns1.0 萬億. Those labels mean 10**12, so the displayed quantity is a thousand times too small. Cambridge's definition of quadrillion is 1,000,000,000,000,000 (1000万亿 / 1000萬億).Changes proposed in this pull request:
千万亿and千萬億in the respective catalogs.Before the catalog change, eight new cases fail and four neighboring-scale cases pass. After recompiling the catalogs, all twelve pass.
Validation on Windows, CPython 3.12.14:
prekhooks passed over the full repository.git diff --checkpassed.This is based on current
mainand is independent of the missing translations in #472. The placeholder migration in #403 touches these entries but retains the incorrect labels; if that merges first, this correction will need to be carried over to its new message IDs.Prepared and tested with OpenAI Codex assistance. Other platforms and Python versions were not run locally.