Repository navigation
Complete missing Simplified Chinese translations - #472
Open
Plastic-time wants to merge 1 commit into
Open
Plastic-time wants to merge 1 commit into
Plastic-time wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
=======================================
Coverage 99.70% 99.71%
=======================================
Files 12 12
Lines 1020 1040 +20
=======================================
+ Hits 1017 1037 +20
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Simplified Chinese catalog has empty translations for zero, milliseconds, microseconds, and the conjunction used by
precisedelta(). Withzh_CNactive, this produces English output such as1 millisecondand mixed output such as1分 and 1秒.Changes proposed in this pull request:
All five regression cases fail with the original compiled catalog. After recompiling the catalogs with polib, the full suite passes on Python 3.12: 881 passed, 2 skipped. The skipped tests require GNU gettext command-line tools, which are unavailable locally; the new Chinese tests all run and pass. Ruff and Black pass for the changed test file.