Skip to content

feat(swift-ios): add reliable text and code sizing - #7612

Merged
t3dotgg merged 1 commit into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:agent/swiftui-text-code-sizes
Sep 6, 2026
Merged

feat(swift-ios): add reliable text and code sizing#7612
t3dotgg merged 1 commit into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:agent/swiftui-text-code-sizes

Conversation

@saphid

@saphid saphid commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The native app had no independent text and code size controls. This adds both controls with live previews in Settings, relative to iOS Dynamic Type.

Size changes apply immediately. Ordered settings writes and rollback to the last successful save prevent older failures or reconnects from restoring stale choices. The update preserves the current environment-owned automatic settlement settings.

Validation: 94 focused native tests passed at dd3fc8b3f42a44f767d7d85c37599c94800c421d, rebased onto SwiftUI base 614a7b672a86ee638f284298fe26e8b0194e0eaa. Coverage includes sizing, settings write order and rollback, legacy settings, and reconnect persistence. Live slider Save and relaunch checks on this updated branch remain incomplete.

Historical images and videos

These captures belong to original head 019c8b219d6fac4845f76ac06348bdc57446b7f3. They were not recaptured or revalidated for the modernized branch.

Light mode before:

Light mode before

Light mode after:

Light mode after

Dark mode before:

Dark mode before

Dark mode after:

Dark mode after

Before video · Interaction video

Tracking: native work item.

Modernized and fixed with GPT-6 in Codex.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8005f269-1ef4-45a9-b292-7f7a0f0cde32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 19, 2026
Comment thread apps/swift-ios/Features/Root/FeatureRootModel.swift
@macroscopeapp

macroscopeapp Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces persisted text and code-size controls with app-wide Dynamic Type behavior and propagation through multiple SwiftUI and UIKit rendering paths. The new settings UI, global trait handling, and serialized save changes make the production impact broad enough to warrant human review.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/swift-ios/Features/Root/FeatureRootModel.swift
Comment thread apps/swift-ios/Features/Root/FeatureRootModel.swift
@saphid
saphid force-pushed the agent/swiftui-text-code-sizes branch from e136164 to f3634dc Compare August 26, 2026 23:05
Comment thread apps/swift-ios/Features/Settings/SettingsView.swift
@saphid
saphid force-pushed the agent/swiftui-text-code-sizes branch from f3634dc to 019c8b2 Compare August 27, 2026 04:07
@saphid saphid changed the title feat(swift-ios): add text and code size controls to Settings feat(swift-ios): add reliable text and code sizing Aug 27, 2026
@saphid

saphid commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Ready for human review on rebuilt current-target head 019c8b219d6fac4845f76ac06348bdc57446b7f3. The vouched 12-item handoff checklist passes: focused native tests are 66/66, exact-base/head simulator proof covers light, dark, independent changes, and relaunch persistence, the in-scope rollback/stale-failure defects are fixed, maintainer edits remain enabled, and the nine-part description/evidence now matches this head. CI triggered by the force-with-lease update is still settling; local affected checks and the exact-head build are green.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 019c8b2. Configure here.

Comment thread apps/swift-ios/Features/Root/FeatureRootModel.swift
@saphid
saphid force-pushed the agent/swiftui-text-code-sizes branch from 019c8b2 to 0eede8d Compare August 28, 2026 12:49
@t3dotgg
t3dotgg force-pushed the agent/swiftui-text-code-sizes branch from 0eede8d to dd3fc8b Compare September 6, 2026 22:10
@t3dotgg
t3dotgg merged commit 7597e3c into pingdotgg:t3code/rebuild-mobile-app-swift Sep 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants