Skip to content

feat(swift-ios): mark Dev and Test builds in the home title - #7453

Open
saphid wants to merge 1 commit into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:feat/issue121-home-channel-title
Open

feat(swift-ios): mark Dev and Test builds in the home title#7453
saphid wants to merge 1 commit into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:feat/issue121-home-channel-title

Conversation

@saphid

@saphid saphid commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

What Changed

Label the SwiftUI Home title “T3 Code Dev” or “T3 Code Test” when a build explicitly declares its channel. Ordinary and unknown channels keep the normal title.

Why

People with multiple native builds installed need to distinguish them. The label uses a declared build setting instead of guessing from a personal bundle identifier.

Verification and remaining proof

Candidate: 0bb6321643348ddba4efa68bd385c03961544398. This PR targets t3code/rebuild-mobile-app-swift; its historical integration base is 22b22f1463b83963d851bd0574a36a20f224a28d. The current native parent inspected in the readiness review is b99405468a6b2be1e0f67d551ece824b1627e35c. Merging this child does not by itself deliver the native app to upstream main.

The hosted native build/test job passed on the candidate. The earlier report records seven PersonalBuildChannelTests, three channel-specific Simulator builds and a successful direct Claude Opus 5 review for this head against 22b22f1. It also records an ENOSPC attempt before the successful test retry; that failure remains part of the evidence. No local build, test or client session was run for this description update; full historical local invocations were not recovered here.

Upstream acceptance of Dev/Test branding remains a scope decision; the readiness review recommends keeping private-distribution branding in its overlay. Current-parent integration and proof remain required if the public contribution is retained. This PR is not evidence-complete for human merge review against the current native parent.

Earlier visual evidence

These retained captures/reports belong to the revisions and conditions stated below. They were not recaptured, visually inspected or revalidated for current-parent integration in this pass. Historical access/playback statements describe the original check, not a new one.

Earlier captures and their original conditions

The original capture report identifies builds of head 0bb632164. The fixture contains one sanitized project and no threads. Dark mode is first, tight title crops are primary, and full-window context is collapsed.

Dark mode

Before, unmarked ordinary build

Ordinary T3 Code title, dark mode

After, Dev build

T3 Code Dev title, dark mode

After, Test build

T3 Code Test title, dark mode

Ordinary, Dev, and Test comparison

Dark-mode build-channel comparison

Live action sequence

Dark-mode historical build-channel identity sequence

Clean dark-mode MP4 | Annotated dark-mode MP4

Full-window context, dark mode

Ordinary

Ordinary T3 Code full window, dark mode

Dev

T3 Code Dev full window, dark mode

Test

T3 Code Test full window, dark mode

Light mode evidence

Before, unmarked ordinary build

Ordinary T3 Code title, light mode

After, Dev build

T3 Code Dev title, light mode

After, Test build

T3 Code Test title, light mode

Ordinary, Dev, and Test comparison

Light-mode build-channel comparison

Live action sequence

Light-mode historical build-channel identity sequence

Clean light-mode MP4 | Annotated light-mode MP4

Full-window context, light mode

Ordinary

Ordinary T3 Code full window, light mode

Dev

T3 Code Dev full window, light mode

Test

T3 Code Test full window, light mode

This section supersedes the earlier screenshot-only proof in the PR conversation.

Tracking: native work item #121.

Implementation: GPT-5.6 Sol high in the Codex harness. Independent review: Claude Opus 5 high, read-only, exit 0, no actionable findings.

Description and evidence audit: GPT-6 in Codex, using prepare-proof-media from #9926.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ca7d1bf3-a4ae-4855-9312-9a5f68d86cb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 19, 2026
Comment thread apps/swift-ios/Features/Workspace/PersonalBuildChannel.swift Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new configuration-controlled Dev/Test marker to the user-facing Home title while leaving ordinary builds and other runtime flows unchanged. The behavior is small and tested, but its core integration changes an existing shared WorkspaceView, so the bounded additive exception does not fully apply.

You can add or adjust custom eligibility rules. Learn more.

@saphid
saphid force-pushed the feat/issue121-home-channel-title branch from 5127c40 to 39f2165 Compare August 19, 2026 21:15
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 20, 2026
@saphid

saphid commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Evidence refreshed on current head

The earlier 69523545 snapshot is superseded. Current-head proof for 0bb6321643348ddba4efa68bd385c03961544398 is now in the PR description: dark-first tight Ordinary/Dev/Test crops, comparison and action GIFs, collapsed full-window and light-mode context, plus clean and annotated MP4s.

Permanent public media: https://github.com/saphid/t3code/releases/tag/pr-7453-evidence-0bb632164-20260830

@macroscopeapp
macroscopeapp Bot dismissed their stale review August 20, 2026 22:01

Dismissing prior approval to re-evaluate 983164b

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 983164b024afda7537266604694c0bd7de0a1864. Configure here.

Comment thread apps/swift-ios/Tests/FeatureTests/PersonalBuildChannelTests.swift
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 20, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 20, 2026 22:22

Dismissing prior approval to re-evaluate 3bcdfec

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 20, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 26, 2026 23:28

Dismissing prior approval to re-evaluate 6737462

@saphid
saphid force-pushed the feat/issue121-home-channel-title branch from 6737462 to cc65bf2 Compare August 27, 2026 03:13
@saphid
saphid force-pushed the feat/issue121-home-channel-title branch from cc65bf2 to 0bb6321 Compare August 27, 2026 05:19
@saphid

saphid commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

@t3dotgg Ready for human review. This is classified direct against live SwiftUI target c49bcc5d8a56324eb0ad9cf1b19d5dcc6ca0caa0: none of the five changed paths overlaps Theo's new commit, and the merge-tree simulation is clean. Head 0bb632164 has green required CI, 7/7 focused native tests, signed exact-head Simulator proof, no unresolved review threads, and successful CodeRabbit, Cursor, Macroscope correctness, and direct Claude Opus 5 high reviews. All 20 proof assets are reachable; the PR body now records the delivery block and exact media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant