feat(swift-ios): mark Dev and Test builds in the home title - #7453
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This adds a new configuration-controlled Dev/Test marker to the user-facing Home title while leaving ordinary builds and other runtime flows unchanged. The behavior is small and tested, but its core integration changes an existing shared WorkspaceView, so the bounded additive exception does not fully apply. You can add or adjust custom eligibility rules. Learn more. |
5127c40 to
39f2165
Compare
Evidence refreshed on current headThe earlier Permanent public media: https://github.com/saphid/t3code/releases/tag/pr-7453-evidence-0bb632164-20260830 |
Dismissing prior approval to re-evaluate 983164b
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 983164b024afda7537266604694c0bd7de0a1864. Configure here.
Dismissing prior approval to re-evaluate 3bcdfec
Dismissing prior approval to re-evaluate 6737462
6737462 to
cc65bf2
Compare
cc65bf2 to
0bb6321
Compare
|
@t3dotgg Ready for human review. This is classified direct against live SwiftUI target |

What Changed
Label the SwiftUI Home title “T3 Code Dev” or “T3 Code Test” when a build explicitly declares its channel. Ordinary and unknown channels keep the normal title.
Why
People with multiple native builds installed need to distinguish them. The label uses a declared build setting instead of guessing from a personal bundle identifier.
Verification and remaining proof
Candidate:
0bb6321643348ddba4efa68bd385c03961544398. This PR targetst3code/rebuild-mobile-app-swift; its historical integration base is22b22f1463b83963d851bd0574a36a20f224a28d. The current native parent inspected in the readiness review isb99405468a6b2be1e0f67d551ece824b1627e35c. Merging this child does not by itself deliver the native app to upstream main.The hosted native build/test job passed on the candidate. The earlier report records seven PersonalBuildChannelTests, three channel-specific Simulator builds and a successful direct Claude Opus 5 review for this head against 22b22f1. It also records an ENOSPC attempt before the successful test retry; that failure remains part of the evidence. No local build, test or client session was run for this description update; full historical local invocations were not recovered here.
Upstream acceptance of Dev/Test branding remains a scope decision; the readiness review recommends keeping private-distribution branding in its overlay. Current-parent integration and proof remain required if the public contribution is retained. This PR is not evidence-complete for human merge review against the current native parent.
Earlier visual evidence
These retained captures/reports belong to the revisions and conditions stated below. They were not recaptured, visually inspected or revalidated for current-parent integration in this pass. Historical access/playback statements describe the original check, not a new one.
Earlier captures and their original conditions
The original capture report identifies builds of head
0bb632164. The fixture contains one sanitized project and no threads. Dark mode is first, tight title crops are primary, and full-window context is collapsed.Dark mode
Before, unmarked ordinary build
After, Dev build
After, Test build
Ordinary, Dev, and Test comparison
Live action sequence
Clean dark-mode MP4 | Annotated dark-mode MP4
Full-window context, dark mode
Ordinary
Dev
Test
Light mode evidence
Before, unmarked ordinary build
After, Dev build
After, Test build
Ordinary, Dev, and Test comparison
Live action sequence
Clean light-mode MP4 | Annotated light-mode MP4
Full-window context, light mode
Ordinary
Dev
Test
This section supersedes the earlier screenshot-only proof in the PR conversation.
Tracking: native work item #121.
Implementation: GPT-5.6 Sol high in the Codex harness. Independent review: Claude Opus 5 high, read-only, exit 0, no actionable findings.
Description and evidence audit: GPT-6 in Codex, using prepare-proof-media from #9926.