Repository navigation
fix(server): Claude threads can allow an MCP app for the session - #33707
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Claude MCP prompts gain an explicit “Always allow this session” choice. Grants remain in memory within the opened session, while ordinary one-time approval behavior stays unchanged. You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…gdotgg#33707) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 4c36119)
Problem
On Claude threads, ChatGPT Computer Use asks "Allow Computer Use to use X?" on every action, and the card only offered a one-time Approve. A short Computer Use task meant approving dozens of times, often several times for one tool call.
The Computer Use server never remembers an answer. The client must. Codex threads already do this: the card offers "Always allow this session" and Codex answers later prompts itself. The Claude adapter only allowed one-time accepts (#21903).
Fix
The Claude elicitation card now offers "Always allow this session". Picking it stores a grant for that MCP server and exact prompt in the adapter session. Later identical prompts get the same acceptance with no card. A different prompt (for example another app) or another server still asks. Grants end with the provider session; "Always allow" across sessions is still not offered.
The Claude CLI strips
_metafrom elicitation replies, so sending_meta.persistto the server would do nothing. The grant lives in T3.Web and mobile need no change; they render the options generically and already show this one on Codex cards.
Proof: a new adapter test that fails on main,
vp run check:changedgreen, and an end-to-end run in a dev server (Claude Haiku thread, stdio MCP server that elicits on every call like Computer Use): one click on "Always allow this session", then all 3 tool calls accepted with a single card.Reviewed with sol-loop: 1 pass with GPT-6.1 Sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code