[ssttevee]

Problem

T3 Code immediately declines MCP URL elicitations from Claude and Codex, so external browser requests never reach the user. Tools requiring authentication must fall back to sending links through the agent.

Related: #14878, which addressed form elicitation.

Change

Route URL elicitations through the existing approval flow across web, desktop, mobile, and child-thread approvals. Users open the destination on their own device, complete the browser steps, and choose Continue. Decline and Cancel retain their existing behavior.

Reuse the existing approval lifecycle, URL-opening APIs, and HTTP(S) URL validation. Claude and Codex share the same one-time response options. Links show their destination host, and the user guide explains remote localhost limitations.

Scope and approval

This PR extends the existing MCP approval capability to URL mode. The related issue's original scope excluded URL authentication; it is context for the existing approval path, not maintainer approval of this extension.

Verification

• vp run check:changed passes: 574 selected tests, affected-package typechecks, formatting, lint, unused-code checks, and React compiler checks.
• Adapter tests cover URL acceptance, decline/cancel, unsupported persistent grants, unsafe URLs, and late responses.
• Native Chrome verification with a local fake Codex provider confirmed that opening the URL leaves approval pending; Continue sends exactly { action: "accept" } and clears the request.
• Native mobile and Electron were not manually exercised.

Screenshots

Pending approval

After Continue

Implemented with GPT-6.1 Sol through the Codex harness in T3 Code. Reviewed by Claude Opus 5.5 and GPT-6.1 Sol.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

MCP URL elicitation now supports validated HTTP(S) links, one-time acceptance, approval URL propagation, and link presentation in web and mobile pending approvals.

Changes: MCP URL Elicitation

Layer / File(s)	Summary
URL validation and approval contracts packages/contracts/src/httpPageUrl.ts, packages/contracts/src/httpPageUrl.test.ts, packages/contracts/src/index.ts, packages/contracts/src/orchestrationV2.ts, packages/contracts/src/orchestratorMcp.ts, packages/contracts/src/secretRequest.ts, packages/contracts/src/secretRequest.test.ts, packages/client-runtime/src/secretRequest.ts	The contracts package adds and exports httpPageUrl, which accepts HTTP(S) URLs with a host. Approval request schemas add optional elicitationUrl. Request-secret URL validation and client-runtime link normalization use the shared helper; the previous helper and its test file are removed.
URL elicitation options and responses apps/server/src/provider/CodexMcpElicitation.ts, apps/server/src/provider/CodexMcpElicitation.test.ts	URL-mode requests use Cancel, Decline, and Continue options. A response accepts only a valid URL with an accept decision; other decisions and invalid URLs are declined.
Approval artifact propagation apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts	Claude and Codex adapters include URL-mode elicitation links in approval items. Tests cover URL cards, decisions, unsafe URLs, and Codex turn completion.
Pending approval link presentation packages/client-runtime/src/state/threadRequests.ts, apps/web/src/components/chat/McpElicitationLink.tsx, apps/web/src/components/chat/ChildThreadApprovals.tsx, apps/web/src/components/chat/TimelinePendingApprovalRow.tsx, apps/mobile/src/features/threads/PendingApprovalCard.tsx, apps/mobile/src/lib/openExternalUrl.ts, docs/user/permission-modes.md	Pending approval state carries elicitation URLs to web and mobile controls. The interfaces display validated links and provide actions to open them. The permission guide describes browser requests.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant MCPServer
  participant CodexMcpElicitation
  participant CodexAdapterV2
  participant PendingApproval
  participant McpElicitationLink
  participant User
  MCPServer->>CodexMcpElicitation: Send URL-mode elicitation request
  CodexMcpElicitation->>CodexAdapterV2: Provide URL and response options
  CodexAdapterV2->>PendingApproval: Add elicitationUrl to approval item
  PendingApproval->>McpElicitationLink: Pass pending approval URL
  McpElicitationLink->>User: Display validated URL and open action
  User->>McpElicitationLink: Select open action
  McpElicitationLink->>User: Open page or show copy-link alert

Loading

Suggested reviewers: t3dotgg, chrischriscris, maria-rcks

Merge Risk: Minimal · up to 519cc

No material issue remains that needs to be fixed before merging. If a browser blocks the link, users can still copy the displayed URL.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "feat(provider): support MCP URL elicitation for Claude and Codex" matches the main change. The changeset routes MCP URL elicitations from Claude and Codex through the existing approval flow…
Description check		The description covers the template's main sections: Problem, Change, Scope and approval, and Verification. It explains the problem (URL elicitations are declined immediately), the change (routing the…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "feat(provider): support MCP URL elicitation for Claude and Codex" matches the main change. The changeset routes MCP URL elicitations from Claude and Codex through the existing approval flow, and the title names both providers and the feature. It is a conventional commit title in plain language, and it is 64 characters and 9 words, which is concise enough.

Full details: Description check

Explanation

The description covers the template's main sections: Problem, Change, Scope and approval, and Verification. It explains the problem (URL elicitations are declined immediately), the change (routing them through the existing approval flow), and the verification (check:changed, adapter tests, and a manual Chrome check, plus what was not tested). It also includes screenshots for the UI change. It does not link a triaged bug issue or maintainer approval. The related issue addresses form elicitation, and the author says that issue does not approve URL mode. The template requires approval for broader behavior changes, so this section is incomplete. The rest of the description is mostly complete, so the check passes with a note about the missing approval.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: c4ce7b0
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 03bb87a8-b698-4787-bb57-2096495f6883

Commits

Reviewing files that changed from the base of the PR and between c4ce7b0 and 519cc62.

Files selected for processing: 21

• apps/mobile/src/features/threads/PendingApprovalCard.tsx
• apps/mobile/src/lib/openExternalUrl.ts
• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts
• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts
• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts
• apps/server/src/provider/CodexMcpElicitation.test.ts
• apps/server/src/provider/CodexMcpElicitation.ts
• apps/web/src/components/chat/ChildThreadApprovals.tsx
• apps/web/src/components/chat/McpElicitationLink.tsx
• apps/web/src/components/chat/TimelinePendingApprovalRow.tsx
• docs/user/permission-modes.md
• packages/client-runtime/src/secretRequest.ts
• packages/client-runtime/src/state/threadRequests.ts
• packages/contracts/src/httpPageUrl.test.ts
• packages/contracts/src/httpPageUrl.ts
• packages/contracts/src/index.ts
• packages/contracts/src/orchestrationV2.ts
• packages/contracts/src/orchestratorMcp.ts
• packages/contracts/src/secretRequest.test.ts
• packages/contracts/src/secretRequest.ts

Files with no reviewable changes: 2

• packages/contracts/src/secretRequest.test.ts
• packages/contracts/src/secretRequest.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.