Repository navigation
fix(web): show pending usage reset credit feedback - #17882
Open
GabrielCoelhoCruz wants to merge 1 commit into
Open
GabrielCoelhoCruz wants to merge 1 commit into
GabrielCoelhoCruz wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused fix to an existing reset-credit interaction, keeping pending and result feedback visible while preventing duplicate in-flight requests. The substantial diff is primarily interaction-test coverage, with no backend, schema, deployment, authentication, or billing logic changes. You can add or adjust custom eligibility rules. Learn more. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Usage → Limits, confirming a reset credit closes the popover and confirmation before the request finishes. The pending button disappears, and the page shows no feedback until the result arrives.
Closes #17449.
Change
Show "Using reset credit…" in the existing status region outside the popover. Keep the result visible when the last available credit disappears.
Bind confirmation, pending text, and results to the account identity. Share the pending guard across controls for the same redemption target, so repeated confirmation cannot attach another account to an old request.
Scope and approval
This is a focused fix for an obvious defect in an existing confirmed action, under the bug-fix exception in CONTRIBUTING.md. The account identity and duplicate guard belong to that same pending operation. Confirmation, cancellation, permissions, eligibility, RPC payloads, and backend redemption rules stay in place.
This covers #17449 only. It does not include preview keyboard changes from #17733 or PR #15035. PRs #17222 and #17705 touch some of the same usage files but address quota grouping and credit balances. This change does not implement those features.
Verification
git diff --checkpassed on current main. Shared typecheck emits an existing advisory insrc/symlink.ts.The external Codex service was replaced by a local protocol fixture. No real credit was redeemed. Account switching has behavioral test coverage, not an integrated account-switch check. Native desktop and mobile were not run. The videos sample the actual page and preserve capture timing.
Exact commands, tested revisions, and limitations
Before recording · After recording
Models used were GPT-6-Astra for implementation, GPT-6-Sol for independent review, and GPT-6.1-Sol for verification, through the Codex harness in T3 Code.