refactor(client-runtime): add project clone sources come from host definitions

[juliusmarminge]

The Add Project helpers in client-runtime listed the hosts by hand: the AddProjectRemoteProviderKind union, two source arrays, the label and path-hint switches, getDefaultCloneUrl's github || forgejo check, and a readiness Record keyed by host. Mobile then repeated the host list twice more, as source === "github" || … route-param guards in AddProjectScreen and AddProjectRepositoryRoute.

Fix

• operations/projects.ts reads hosts, labels (pickerLabel), path hints and the clone transport from sourceControlClients. AddProjectRemoteSource is SourceControlProviderKind | "url".
• Readiness is now a lookup function ((source) => { ready, hint }) instead of a record with one key per host, so it covers whatever hosts the definitions list.
• New parseAddProjectRemoteSource replaces mobile's two route-param guards. A host this build doesn't ship falls back to url, as before.
• On mobile, SourceControlIcon takes the definition's icon key and draws nothing for keys it has no art for. thread-pr-presentation reads the change request noun from the definition.

No behavior change. Labels, hints, ordering (ready first, then by label), hint copy and clone transports are identical.

I deliberately left mobile's "new project → private GitHub repository" alone. It publishes through gh and reads getNewProjectGitHubTarget, so it is a GitHub feature, not a host switch.

Verification

• npx tsc --noEmit -p . is clean in client-runtime and mobile.
• vp test run packages/client-runtime/src/operations/projects.test.ts apps/mobile/src/state/use-thread-pr.test.ts packages/client-runtime/src/sourceControlClients.test.ts passes. The existing readiness test now calls the resolver form.
• vp lint on the touched files and knip are clean.
• Effect-shortcut grep over the added lines finds nothing.

After restacking onto GitCafe (#17681): GitCafe joins the clone picker through its definition, with no edit to this layer's code. That matches what main's palette offers. Mobile's SourceControlIcon gains GitCafe's mark, the same inset square as web's GitCafeIcon.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The mobile clone flow now automatically exposes host definitions such as GitCafe, including new labels, icons, readiness handling, repository lookup, and clone transport behavior. This changes the product's default source choices and enables a new user-facing path, so the broader runtime impact merits human review.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

No code changes detected at efcc177. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Codex	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Codex	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Codex	Live turn WebSocket decoded	—	20.9 KiB	—	29.3 KiB	✅
Codex	Live turn messages	—	2	—	8	✅
Claude	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Claude	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Claude	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Claude	Live turn WebSocket decoded	—	21.2 KiB	—	29.3 KiB	✅
Claude	Live turn messages	—	1	—	8	✅

Baseline: unavailable · PR result: efcc177 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 56760f2c-7512-4574-a2d9-4eb61f83dae3

---

📥 Commits

Reviewing files that changed from the base of the PR and between f4c6dfb and efcc177.

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: e390f8df-47ae-4099-810c-8675f02ed149

---

---

---

📥 Commits

Reviewing files that changed from the base of the PR and between c1581e0 and f4c6dfb.

---

---

---

📒 Files selected for processing (1)

• packages/client-runtime/src/operations/projects.test.ts

---

---

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

---

---

---

📝 Walkthrough

📝 Walkthrough

📝 Walkthrough

Walkthrough

The add-project source model derives provider names, labels, path hints, clone transport, and readiness from registered source-control clients. Mobile routes parse unknown sources as URLs, use configured icons, and query readiness by source. Thread PR accessibility labels use the selected client’s singular change-request name.

Changes

Source-control provider integration

Layer / File(s)	Summary
Source definitions, parsing, and readiness packages/client-runtime/src/operations/projects.ts, packages/client-runtime/src/operations/projects.test.ts	Provider source details and readiness use registered source-control clients. Missing or unknown values parse as url. The readiness test uses the callable API and retains its expected states and GitLab hint.
Add-project source selection apps/mobile/src/components/SourceControlIcon.tsx, apps/mobile/src/features/projects/AddProjectRepositoryRoute.tsx, apps/mobile/src/features/projects/AddProjectScreen.tsx	Add-project routes use the shared parser and labels. The screen uses client-configured icons and queries readiness by source. SourceControlIcon renders GitCafe and returns null for unsupported values.
Thread change-request labels apps/mobile/src/state/thread-pr-presentation.ts	Thread PR presentation uses the selected client’s change-request descriptor and singular name in the accessibility label.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Refactor

---

---

---

---

Merge Risk: ⚪ Minimal · up to f4c6d

The summarized change updates test calls without changing expected readiness behavior. No actionable merge risk remains in the reviewed change.

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the refactor that makes project clone sources come from host definitions.
Description check		The description explains the problem, changes, behavior, and focused verification. It does not include the template’s Scope and approval section or link approval, but the remaining information makes t…

---

---

---

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

---

---

---

---

---

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

---

---

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate c1581e0