Repository navigation
Conversation
|
Thank you for this thoughtful work on Simplified Chinese settings and navigation! The reactive locale switching and Chinese settings search are fantastic additions. We are cheering for this and the shared i18n foundation to land upstream. Huge thanks for pushing this forward! 👍 |
Collaborator
|
Note Written by Hi! We are cleaning up open PRs, and this one names a harness (Codex) but not which model version created it. If this change is really important, we recommend rebuilding the PR with a newer model and noting the model in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Current main has English-only interface copy and no persisted interface-language control. Chinese-speaking users cannot opt into a localized interface without a fork. This addresses one problem: a device-local, reversible Simplified Chinese interface preference with an initial translated settings surface.
Change
interfaceLanguage: en | zh-CNto client settings and the patch schema; existing settings decode to English. No automatic locale negotiation and no changed language default.html.langabove the router, including non-shell routes.This is incremental localization, not a whole-app translation. Advanced settings dialogs, other settings pages, chat/tool output, Electron-native menus, and the remaining mobile screens still use their existing copy.
Direction and related work
Related: Simplified Chinese discussion #6789, the maintainer's cross-client coverage comment, and the existing foundation proposal #16087. This implementation differs by retaining English as the default and avoiding new i18next/react-i18next dependencies. It is a community proposal, not a claim that the other contributor's work has merged or that this specific implementation has separate maintainer approval. If #16087 becomes the chosen foundation, this catalog/surface can be adapted to it rather than maintaining two systems.
Verification
Windows, Node 24.19.0, pnpm 11.10.0, current main base
740bda40c92e1ded65dd2b65ef7c583357b1d258.vp test run packages/contracts/src/settings.test.ts apps/web/src/components/settings/settingsSearch.test.ts apps/web/src/clientPersistenceStorage.test.ts→ 227 passed, exit 0.vp test run packages/contracts/src/settings.test.ts \ packages/client-runtime/src/i18n/index.test.ts \ apps/web/src/components/settings/settingsSearch.test.ts \ apps/web/src/hooks/useSettings.test.ts \ apps/web/src/clientPersistenceStorage.test.ts \ apps/web/src/i18n.test.tsx \ apps/web/src/components/settings/SettingsPanels.restore.test.tsx \ apps/mobile/src/persistence/mobile-preferences.language.test.ts \ apps/web/src/components/settings/settingsLayout.test.tsx \ apps/web/src/components/settings/scopedSettings.test.ts \ apps/mobile/src/state/preferences.test.ts→ 298 passed in 11 files, exit 0. Tests cover old-setting defaults, invalid language rejection, client-only patches, Chinese translation and English fallback, interpolation, reactive rendering and
html.lang, reload/reverse switching, reset-to-English, Chinese search destinations, and actual mobile store save/reload/sanitization.tsc --noEmit→ exit 0; targetedvp lint→ exit 0 with existing warnings; formatter andgit diff --checkpass.vp build→ exit 0 (existing large-chunk warnings)..t3-zh-cnstate: English → 简体中文 changes text immediately; reload retains 简体中文 andhtml.lang=zh-CN; switching back restores English andhtml.lang=en, including after reload. Searching时间格式finds the translated row and scrolls/focuses its actual setting. Light-mode screenshots below.Desktop-native menus and a physical iOS/Android client were not exercised. The Electron renderer shares the verified web implementation; mobile evidence is typechecking and store tests, not native-device acceptance. No repo-wide checks were run.
Screenshots
English and Chinese before/after switching the language on the same build, not screenshots of an unmodified upstream build. Images are GitHub release assets on the fork, not committed to the source tree.
Model: exact model identifier not exposed in this session. Harness: OpenAI Codex desktop.