i18n(ja): convert full-width hash to half-width in issue/PR references - #23597
Closed
yahonda wants to merge 7 commits into
Closed
i18n(ja): convert full-width hash to half-width in issue/PR references#23597yahonda wants to merge 7 commits into
yahonda wants to merge 7 commits into
Conversation
…erences The Japanese translation rendered the # in GitHub issue/PR link text (e.g. [＃12345]) as the full-width CJK character ＃ instead of the half-width # used throughout the English source and in the actual linked URLs. Converts all 9024 occurrences across 166 files to match. Also fixes 42 occurrences of the same pattern in resources/doc- templates/patch_release_note_template_zh.md's placeholder text ([＃問題]), where the character wasn't followed by digits but still represents the same GitHub issue-number marker.
|
Important Review skippedToo many files! This PR contains 166 files, which is 16 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (166)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
…e notes
- release-2.0.10.md, release-2.1.1.md (x2): "しないでください" reads as
a command to the reader, but the English source ("Avoid transferring
the leader...") describes a system behavior change, not a user
instruction. Changed to "しないようにします" to match.
- release-2.0.5.md: missing が and を particles, and 必要となる (which
needs が) mismatched with the を already present; fixed to the
consistent transitive form 必要とする.
…notes - release-2.0.9.md: 構成→設定 for "configuration" (matches the pingcap#23596 direction decision) - release-2.1-rc.1.md: 3 missing を/の particles, plus fixed scrambled word order in the Scope-check bullet
…r in 10 release notes
Found by independent 1:1 EN review of this PR's changed files:
- 5 misleading imperative/cohortative renderings ("してください"/
"しましょう") of English descriptions of tool/system behavior changes,
not user instructions
- 5 issue-link references wedged mid-sentence, splitting a
paired/compound term (e.g. ENUM/SET, start-ts/checkpoint-ts) instead
of sitting at the end of the bullet
- release-3.0.20.md: typo 削除れない → 削除しない (missing さ) plus
restructured sentence
- release-3.1.0-ga.md: spurious dangling が particle with no referent
- release-6.5.10.md/7.1.6.md/7.5.2.md: rewrote a heavily garbled paragraph (spurious ordinal 目/件目 counters, a fabricated "13件目", dangling してください with no governing verb) to match the English source's TiCDC UPDATE-split-behavior description (pingcap#10918) - ticdc/ticdc-split-update-behavior.md: removed a stray つ inserted after every `DELETE`と`INSERT` mention (6 sites) - release-7.1.0.md, release-7.1.3.md: removed spurious unclosed full- width parentheses not present in the English source - release-7.5.4.md: fixed a garbled trailing clause ("in some cases") that had become a dangling 場合） with an unmatched parenthesis - release-6.5.12.md/7.5.5.md/8.1.2.md: fixed duplicated の (負のの→負の) - release-8.1.1.md: misleading imperative 変更してください→変更します (describes a change TiDB itself made, not a user instruction) - release-6.5.3.md: a literal BR error-message string ("resolve lock timeout") had been translated into Japanese, misrepresenting what actually appears in the tool's output; restored to the literal string - release-6.5.11.md/7.1.6.md/7.5.3.md: 構成項目→設定項目 for the same referent repeated two sentences later as 設定項目 (matches the pingcap#23596 direction; these release-note files were missed by that sweep)
…release notes (batch 1)
…ranslations in 10 release notes (batch 3)
Member
Author
|
Splitting this PR into two smaller PRs to stay under CodeRabbit's 150-file review limit (this PR touched 166 files, 16 over the limit):
Both are byte-identical to this PR's content for their respective file subsets. Closing in favor of the two split PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
The Japanese translation rendered the
#in GitHub issue/PR reference link text (e.g.[#12345]) as the full-width CJK character ＃ instead of the half-width#used throughout the English source and in the actual linked URLs.Converts all 9024 occurrences of ＃ to half-width
#across 166 files. This includes 42 occurrences inresources/doc-templates/patch_release_note_template_zh.md's placeholder text ([＃問題]), where the character isn't followed by digits but still represents the same GitHub issue-number marker.Verified: 0 remaining full-width ＃ occurrences, line-count-symmetric diff (8510 lines changed, no additions/removals).
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?