[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Dot notation operation on a missing field reveals whether the field is stored to a caller without read access (GHSA-4m87-fqwv-2m8v)

Tasks

• Add tests

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 72fd2f75-d5ec-4ea9-a316-cef804e33dfe

Commits

Reviewing files that changed from the base of the PR and between 9805d3e and 72cb4fa.

Files selected for processing: 2

• spec/vulnerabilities.spec.js
• src/Controllers/DatabaseController.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The controller now avoids recursing into absent or non-object key-path segments when expanding update results. Vulnerability specs cover dot-notation responses for unreadable fields, missing paths, triggers, MongoDB array indexes, master-key requests, and create operations.

Changes: Dot-Notation Responses

Layer / File(s)	Summary
Missing-path expansion and regression coverage src/Controllers/DatabaseController.js, spec/vulnerabilities.spec.js	The controller keeps the current child object when a key-path segment is absent or is not an object. Specs cover update and create responses across missing paths, trigger configurations, MongoDB array indexes, and master-key requests.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: Minimal · up to 72cb4

No merge-blocking issue was identified.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

Failed checks: 1 error

Check name	Status	Explanation	Resolution
Description check		The pull request has no description. It does not provide the required Issue, Approach, or Tasks information from the repository template.	Add a pull request description that includes the Issue, Approach, and Tasks sections. Identify the security issue, summarize the code and test changes, and mark applicable tasks as complete.

Passed checks: 6 passed

Check name	Status	Explanation
Title check		The title starts with the required fix: prefix. It identifies the security advisory addressed by the changes, and the first character after the prefix is capitalized.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Security Check		The changed controller code hardens _expandResultOnKeyPath by requiring an own object property before descending into the database result. If a path is absent, it keeps the empty response child and …
Engage In Review Feedback		PASS: No review feedback comments were supplied for this pull request. The current review produced zero actionable findings, and no CodeRabbit review threads were returned. There was therefore no feed…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Full details: Security Check

Explanation

The changed controller code hardens _expandResultOnKeyPath by requiring an own object property before descending into the database result. If a path is absent, it keeps the empty response child and does not read below the hidden path. The added GHSA-4m87-fqwv-2m8v tests cover missing parents, stored paths, master-key behavior, arrays, triggers, and SDK state cleanup. No new security-vulnerable pattern is introduced by the pull request.

Full details: Engage In Review Feedback

Explanation

PASS: No review feedback comments were supplied for this pull request. The current review produced zero actionable findings, and no CodeRabbit review threads were returned. There was therefore no feedback requiring engagement, implementation, or discussion.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Pre-merge checks failed. Please resolve the failing checks before merging.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (bec1c70) to head (72cb4fa).
⚠️ Report is 4 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10842   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files         193      193           
  Lines       17378    17379    +1     
  Branches      246      246           
=======================================
+ Hits        16366    16367    +1     
  Misses        991      991           
  Partials       21       21           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.10.8-alpha.1

[parseplatformorg]

🎉 This change has been released in version 9.11.0