Skip to content

ci: add generated protobuf files to sdist and wheel#46

Closed
gruebel wants to merge 1 commit into
open-feature:mainfrom
gruebel:package-proto
Closed

ci: add generated protobuf files to sdist and wheel#46
gruebel wants to merge 1 commit into
open-feature:mainfrom
gruebel:package-proto

Conversation

@gruebel

@gruebel gruebel commented Feb 22, 2024

Copy link
Copy Markdown
Member

This PR

  • leveraged hatch-build-scripts plugin to run the gen_protos.sh
  • fixed the gen_protos.sh file to correctly the paths
  • had to add ignore-vcs = true to make it all work, otherwise hatch just ignored the generated files

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested a review from a team as a code owner February 22, 2024 21:57
@federicobond

Copy link
Copy Markdown
Member

Closing this in favor of #45, committing the generated files for now. Thank you @gruebel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants