Skip to content

fix: include proto file in build for openfeature-provider-flagd#45

Merged
federicobond merged 2 commits into
open-feature:mainfrom
federicobond:fix-build
Feb 23, 2024
Merged

fix: include proto file in build for openfeature-provider-flagd#45
federicobond merged 2 commits into
open-feature:mainfrom
federicobond:fix-build

Conversation

@federicobond

Copy link
Copy Markdown
Member

This should fix #44. hatch now generates the proto client files during the build stage.

We can probably find a cleaner solution later.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond requested a review from a team as a code owner February 22, 2024 21:56
@federicobond federicobond requested a review from gruebel February 22, 2024 21:56
@codecov

codecov Bot commented Feb 22, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 41.02564% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 71.04%. Comparing base (d8e10c7) to head (8e8ff2e).
Report is 7 commits behind head on main.

Files Patch % Lines
...ntrib/provider/flagd/proto/schema/v1/schema_pb2.py 24.00% 38 Missing ⚠️
.../provider/flagd/proto/schema/v1/schema_pb2_grpc.py 53.73% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   90.55%   71.04%   -19.52%     
===========================================
  Files           8       10        +2     
  Lines         180      297      +117     
===========================================
+ Hits          163      211       +48     
- Misses         17       86       +69     
Flag Coverage Δ
unittests 71.04% <41.02%> (-19.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond

Copy link
Copy Markdown
Member Author

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

@gruebel gruebel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a similar solution, but yours seems better 😄

Comment thread providers/openfeature-provider-flagd/pyproject.toml Outdated
@gruebel

gruebel commented Feb 22, 2024

Copy link
Copy Markdown
Member

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

the plugin requires Python 3.9 😢

@toddbaert

toddbaert commented Feb 22, 2024

Copy link
Copy Markdown
Member

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

No worries!

Bummer about 3.8... Looks like it isn't eol until October... Not sure we should drop early, but that's an option.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond merged commit 7783cc8 into open-feature:main Feb 23, 2024
@federicobond federicobond deleted the fix-build branch February 23, 2024 14:07
jonathannorris added a commit that referenced this pull request Jun 22, 2026
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError when importing flagd provider

4 participants