Skip to content

Banner: add link to Unhandled Rejections survey - #3336

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
mmarchini:unhandled-rejections-survey-banner
Aug 12, 2020
Merged

MylesBorins merged 1 commit into
nodejs:masterfrom
mmarchini:unhandled-rejections-survey-banner

Conversation

@mmarchini

Copy link
Copy Markdown
Contributor

We're seeking input from the community on the longstanding unhandled
rejections deprecation. The survey will run for ~2 weeks

Ref: nodejs/TSC#902

We're seeking input from the community on the longstanding unhandled
rejections deprecation. The survey will run for ~2 weeks

Ref: nodejs/TSC#902
@mmarchini

Copy link
Copy Markdown
Contributor Author

@nodejs/website pinging since this is time-sensitive.

Also cc @nodejs/tsc for awareness

@mmarchini

Copy link
Copy Markdown
Contributor Author

Happy to hear suggestions for the text. An alternative I've considered was Unhandled Promise Rejections survey now available (both use about the same space on the banner)

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

Copy link
Copy Markdown
Contributor

Based on multiple reviews and time sensitivity I'm going to land this, if we want to bikeshed text lets open another PR

@MylesBorins
MylesBorins merged commit a04d99f into nodejs:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants