Repository navigation
Node.js TSC Survey: Unhandled Promises #902
Description
Activity
all the code blocks are missing indentation and the one at the top is cut off:
The first question seems to be asking about selecting multiple things but its a radio, same with second question. questions 3 and 4 have the same question text
Reacted by Joe Sepi, Rachel Romoff and Tobias NießenThanks for this, @devsnek
- I've gone through and fixed formatting on the code blocks, however, the character limit is 4000, and it's cutting off the summary. I'm exploring adding screenshots to save character count, however, we can also use the first paragraph and link to an issue or blog post for additional context.
- For question number 1. Are you currently using Promises, async functions, a mix, or neither?, and 2.How are you handling rejections today? do we want to provide the option for more than one selection? I can change that to a check all that apply.
- I've updated question 4 with the right copy.
Reacted by mary marchiniThanks. For the header, the only thing i would say there is that screenshots would not be ideal for people who use screenreaders, unless it provides the option for alt text. For question one, I think check all that apply is the best.
Reacted by Rachel RomoffFound some formatting issues and inconsistencies with the original proposed survey. @RRomoff let me know if you have any questions.
Question 2 is missing the summary after the title. Summary should be:
When consuming Promises, async functions or thenables, which of the options below do you use to handle rejections?
SurveyMonkey:
Proposed question:
Options to question 3 are incorrect:
Should be:
- I use
process.on('unhandledRejection') - I don't use
process.on('unhandledRejection') - I didn't know
process.on('unhandledRejection')existed
Question 5 in our proposed questions is missing: https://github.com/nodejs/TSC/blob/master/surveys/promise-rejections/survey.md#do-you-know-that-nodejs-has-a-global-handler-for-uncaught-exception-processonuncaughtexception-if-so-do-you-use-it
Question 7(
When a rejected promise doesn't have a catch handler, what is the behavior of your application today?):- should be a radio button to select only one option
- Match formatting after the code block with formatting before the code block.
Question 8:
Extra
aafterdatabaseConnection.releasein one of the options+ - [ ] I make sure (...) `databaseConnection.release`a throws(...) - - [ ] I make sure (...) `databaseConnection.release` throws(...)
Question 9:
Consider the following modes:missing- Not sure if it's possible, but
Other (please elaborate)is clearer for this question thanOther (please specify)(as we expect users to describe the mode they want if they select Other).
Reacted by Joe Sepi- I use
The survey is available at: https://www.surveymonkey.com/r/FTJM7YD
We also wrote an accompanying blog post for extra context: https://medium.com/@nodejs/node-js-promise-reject-use-case-survey-98e3328340c9
The survey will run for at least two weeks, at which point we'll evaluate if the number of replies is enough for us to move forward, otherwise we might extend it for a week or two. Please fill out the survey as it will help us decide the future of unhandled promise rejections on Node.js!
Reacted by Michael Dawson- added a commit that references this issue
on Aug 12, 2020 - added a commit that references this issue
on Aug 12, 2020 Linking here for TSC visibility: #857 (comment)
we reached our target number of responses (with 5 days left! 🎉). The survey will continue until Monday as planned, once it closes we'll share the results.
Reacted by Matteo Collina and Benjamin GruenbaumReacted by Michaël Zasso and Michael DawsonWe got a total of 2,423 responses. Results are available at https://www.surveymonkey.com/results/SM-82X6PX3B7/, we'll be sharing the free-form results (Other field) as well soon too. I'll open a PR to add the results to this repo later.
Reacted by Matteo Collina@joesepi, @mmarchini I think this can be close now ?
Reacted by Joe Sepi
Hey friends. I'm here to close the loop on spinning up this survey. Sorry for the delay.
Everything should be in place. See survey link below and respond in this issue if it needs updates/fixes.
Note: Survey Monkey doesn't allow markdown or code formatting in answers, so we decided to use bold to denote actual code in answers. Not ideal but is what it is.
The foundation suggested (and I think its a great idea) to do a blog post about the survey and follow up with results. I'm working with @mmarchini to quickly put that together, but it doesn't need to hold up the survey if we aren't fast enough, although it would be best to put it all out there at once.
Survey: https://www.surveymonkey.com/r/FTJM7YD
(Let's be sure its reviewed before blasting it out to the world)
References:
process.unhandledRejectionsruntime flag OPEN PRBelow is what the foundation provided back to me. As we flesh out User Feedback Surveys at the foundation, the copy below will be abstracted into the user feedback repo as how the foundation can support requests like these. If anyone has any feedback on executing this survey or surveys in general, please let me know. I'm always wanting to make things better. And the more we have this formalized, the speedier they can be turned around. Thanks!
Node.js TSC Survey: Unhandled Promises
OpenJS Foundation Support Plan
Objective
To provide the Node.js TSC insights and feedback via survey data for decisions pertaining to Unhandled Promises.
Foundation Support to include:
Additional Requirements
The Foundation would like to include an optional question requesting name and email. This is to provide survey results back to the respondent as well as collect contact information regarding people interested in the technical direction of Node.js.
Note: this copy currently reads as such
Personally, I think that copy should make it more clear that it is optional and I will work to get that updated to: