Repository navigation
Merge upstream v0.0.46-nightly.20261011.2994 - #5
Conversation
…service conventions (pingdotgg#17544) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#17545) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#17559) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…#16674) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Ben Davis <bmdavis419@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…pingdotgg#17599) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ract (pingdotgg#17602) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#17573) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rgejo (pingdotgg#17581) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ol-azure-devops (pingdotgg#17592) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…lab (pingdotgg#17594) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…bitbucket (pingdotgg#17597) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hub (pingdotgg#17607) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#17576) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#17577) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#17578) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#17579) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#17615) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…st kinds (pingdotgg#17617) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…not its kind (pingdotgg#17619) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g move into their packages (pingdotgg#17624) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#17879) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…17050) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#17027) Co-authored-by: Julius Marminge <julius0216@outlook.com>
There was a problem hiding this comment.
💡 Codex Review
t3code/apps/web/src/components/ChatView.tsx
Lines 4313 to 4317 in d50d103
Suppress the cache timer unless the latest run matches the currently selected provider and model. After a user changes the composer’s provider or model, activeProviderStatus reflects the new choice while modelSlug still comes from the persisted thread selection and activeLatestRun.completedAt belongs to the previous turn; the badge consequently presents a fresh cache countdown for a provider/model that has not run.
AGENTS.md reference: AGENTS.md:L156-L158
Add auto to this predicate. The comment and Cursor usage data identify Auto as part of Cursor’s own-model pool, for which cacheTtlMinutes intentionally returns no estimated prompt-cache lifetime, but the current condition recognizes only default, Composer, and Grok. Threads using the supported model: "auto" selection therefore show a misleading 5-minute cache timer.
AGENTS.md reference: AGENTS.md:L156-L158
t3code/.github/workflows/fork-upstream-sync.yml
Lines 52 to 56 in d50d103
This safety step runs before checkout and the upstream merge, so it can disable only workflows already registered in the fork; gh workflow list --help describes the command as listing workflow files, and a path newly introduced by the fetched nightly does not exist in the repository yet. On either the clean-merge push or the conflict branch/PR push, that new upstream workflow is therefore published while active and can run before the next daily sync, exactly the publish risk this step is intended to prevent.
t3code/apps/web/src/components/ui/sidebar.tsx
Lines 33 to 35 in d50d103
Scope the menu hold to a menu opened from the peeking sidebar rather than any [role="menu"] in the document. If the user moves from the peeking sidebar to an unrelated menu elsewhere in the chat or right panel, the close timer repeatedly finds that menu and keeps the sidebar overlay pinned over the workspace until the unrelated menu closes.
t3code/apps/web/src/components/chat/ComposerUsageStrip.tsx
Lines 282 to 283 in d50d103
Apply relevantWindows to secondary accounts as well as the selected account. With multiple subscriptions, expanding a secondary Cursor account currently maps its raw windows and displays Overall beside Cursor Models and Other Models, even though Overall is the aggregate of those pools rather than a third quota; the collapsed “tightest” calculation can likewise select that aggregate.
AGENTS.md reference: AGENTS.md:L156-L158
t3code/apps/web/src/components/ThreadTerminalDrawer.tsx
Lines 733 to 734 in d50d103
copySelection catches clipboard failures internally, so this unconditional clearSelection() also runs when nothing was copied. In a remote browser where clipboard writes and the execCommand fallback are unavailable or denied, a plain right-click reports the error but destroys the selected terminal text, preventing the user from retrying; return a success result and clear only after a successful write.
AGENTS.md reference: AGENTS.md:L19-L21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -9,6 +9,7 @@ import { | |||
| import { ChatCanvasContext } from "./ChatCanvasContext"; | |||
| import { resolveChatCanvasLayout, type ChatCanvasPreview } from "./chatCanvasLayout"; | |||
| import type { PreviewMiniPlayerObstacles } from "../preview/previewMiniPlayerLayout"; | |||
| import { observeResize } from "../../lib/observeResize"; | |||
|
|
|||
| /** The elements whose rules in index.css read the chat lane variables. */ | |||
| const CHAT_LANE_SELECTOR = ".chat-composer-lane, .messages-timeline-scroll, .chat-scroll-to-bottom"; | |||
There was a problem hiding this comment.
Update the banner lane’s non-inherited variables
Include .chat-banner-lane in CHAT_LANE_SELECTOR. The new @property declarations make these variables non-inherited, but this selector updates only the composer, timeline, and scroll button. When a preview or details card adds a chat inset, provider/error banners therefore retain the initial zero inset and extend underneath the side panel instead of following the conversation lane.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Claude Code resolved the conflicts in this merge of upstream
v0.0.46-nightly.20261011.2994. Typecheck passed.Merging this PR builds and publishes the update.
Claude's summary
The merge is resolved and staged but not committed. No conflict markers are left, and typecheck passes with 0 errors after one fix. The tests I ran pass:
driver.test.ts(2 tests),ChatView.logic.test.tsandsidebar.test.tsx(129 tests).ChatComposer.tsxandComposerUsageStrip.tsxhave no unit tests of their own, so those two are covered only by typecheck. The lockfile didn't conflict, but I ranvp installanyway because the merge added a new package.ensure:electronsucceeded.Conflicts:
apps/web/src/components/ChatView.tsxwidthStorageKey), so resizing the panel doesn't redraw the whole chat view. Upstream instead held that width in ChatView, measuring the workspace row (usePreviewPanelInlineSizewithcontainer).FileMetadataThreadProviderimport and theconst content = (...)wrapper that uses it.apps/web/src/components/chat/ChatComposer.tsxuseComposerActionRowalready measures and watches those buttons in that state, and also handles moving a long prompt onto its own row.ref. Everything else upstream changed in the file merged as is.apps/web/src/components/ui/sidebar.tsxpackages/provider-cursor/src/server/driver.test.tsHttpClientResponse.HttpClientResponse.packages/provider-cursor/src/server/usageLimits.ts.Typecheck fix: upstream removed
getDriverOption, which the fork'sComposerUsageStrip.tsxstill called. I switched it to upstream's replacement,providerClients.get(provider.driver). That is the only file I edited outside the four conflicts, and only because of the type error.