Skip to content

Upgrade Jedi to version 0.13.3.#6317

Merged
ericsnowcurrently merged 6 commits intomicrosoft:masterfrom
ericsnowcurrently:jedi-upgrade
Jun 25, 2019
Merged

Upgrade Jedi to version 0.13.3.#6317
ericsnowcurrently merged 6 commits intomicrosoft:masterfrom
ericsnowcurrently:jedi-upgrade

Conversation

@ericsnowcurrently
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently commented Jun 24, 2019

(for #6013)

Note that the update to the change log is a one-off for the sake of whoever does the July release. They will adjust as needed. :)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@DonJayamanne
Copy link
Copy Markdown

I believe the following line of code needs to be removed self.environment = jedi.api.environment.Environment(sys.prefix, sys.executable) in https://github.com/microsoft/vscode-python/blob/46fbac3d5f5b661d6d740de0c67b8fa35bec4d55/pythonFiles/completion.py

@ericsnowcurrently ericsnowcurrently merged commit aab1520 into microsoft:master Jun 25, 2019
@ericsnowcurrently ericsnowcurrently deleted the jedi-upgrade branch June 25, 2019 17:59
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants