Repository navigation
Make contextFlags an explicitly required parameter - #49720
Merged
Jake Bailey (jakebailey) merged 2 commits intoJul 6, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Jake Bailey (jakebailey)
requested review from
Nathan Shively-Sanders (sandersn) and
Wesley Wigham (weswigham)
July 6, 2022 21:53
Wesley Wigham (weswigham)
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #49707.
There are more places we don't pass
contextFlagsdown; make the parameter required to make it harder to forget to pass it.It seems to me that all of the cases where we add
contextFlagsto a call are bugs, but I haven't been able to think up any test cases to exhibit them. e.g., I would think that you could create a test somewhat like that in #49707 but where the inferred type is in ayield, but I'm not sure how.