Repository navigation
Pass contextFlags when getting contextual type of JSX elements/attributes - #49707
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Jake Bailey (jakebailey)
requested review from
Nathan Shively-Sanders (sandersn) and
Wesley Wigham (weswigham)
June 28, 2022 16:43
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jun 28, 2022
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44596
The context flags were not being passed through when working with JSX elements/attributes, which meant that
instantiateContextualTypedidn't use the inferences to instantiate the signature.I think it'd be best if the
contextFlagsparameter were required, and I have a change that does so (we don't pass flags in a few more places, likely also unintentionally), but doing so doesn't seem to reveal any baseline changes. I was hoping that #45596 could be fixed as a result, but just fixing up the flag plumbing doesn't seem to help.