Repository navigation
MDN description V2 - #2171
MDN description V2#2171
Conversation
|
I have updated it Kagami Sascha Rosylight (@saschanaz), |
Kagami Sascha Rosylight (saschanaz)
left a comment
Kagami Sascha Rosylight (saschanaz)
left a comment
There was a problem hiding this comment.
I think you reverted too early. The module error doesn't happen locally.
| | (startswith("/en-us/docs/web/api/") or startswith("/en-us/docs/webassembly/reference/javascript_interface/"))) | ||
| ) | ||
| | { mdn_url, pageType, summary } ] }' \ | ||
| > mdn.json |
There was a problem hiding this comment.
Why do bash magic when we can filter it in the script instead?
|
The module error also occurs on my local machine (Ubuntu), Kagami Sascha Rosylight (@saschanaz). I used the bash magic because it significantly reduces the output size — most of the data isn’t needed. Current (filtered and formatted): 2.5 MB Original (unfiltered, unformatted): 28.7 MB That’s over 11× larger (28.7 MB vs 2.5 MB), so I think the extra shell step is worth it. |
|
I’ve added support for _static, so there is no missing comments now, Jake Bailey (@jakebailey). |
Are you seeing the exact same module error? Because that error says you don't have lib/build.js, which means typescript silently failed to compile anything at all. Can you check what's in lib/ in that case?
Hmm, fair. I think we should still fetch and filter in typescript instead, as bash usage would break on Windows. |
|
Or well, in JS, to save a build step. |
I don't think that this is an issue, since no one would actually run it, but sure, I will write a script to generate the file |
|
|
Can you check what's in lib/ in that case? |
Here
|
|
How are you able to apply changes to the PR? |
With a hack - Adam Naji (@Bashamega) also opened saschanaz#241 and that grants me some sort of access. But only through GitHub UI and no direct git push. |
|
Interesting, did not know that GitHub allowed a branch to be open to two PRs even across repos. |
|
Thanks for helping Kagami Sascha Rosylight (@saschanaz), I will pull and fix the code right now, give me 5-10 minutes |
Cool, I'll stop making changes until then. |
|
I have updated the MDN file Kagami Sascha Rosylight (@saschanaz) |
I think the best thing to solve this issue with permission to invite Kagami Sascha Rosylight (@saschanaz) as a collaborator for this repository :) |
|
Apparently Microsoft didn't like that idea 🥺 |
|
I have a plan to fix the old workflow; I think I just over-classified the repo which locked out some things. (Will take a bit for the system to update repo rules.) |
|
I hope you can gain access |
|
Also, for the future if you don't mind Kagami Sascha Rosylight (@saschanaz) |
|
There's a dom lib channel on the discord, fwiw |
|
Everything in order now? (This is a maintained tagged PR so I have to merge it anyway, just let me know) |
I know but I think Kagami Sascha Rosylight (@saschanaz) is not on discord or inactive |
|
I think mostly fine but I'll check again in 30min |
|
Actually, LGTM |
|
Sorry Kagami Sascha Rosylight (@saschanaz), you don't have access to these files: |
|
Thanks |
|
I'll check back then if I'm still awake (my fire alarm went off in the middle of the night, I'm not normally around at this time...) |
|
Oh, good |
Migrate to be using the json API
closes #2151
closes #2086
closes #2078
closes #2209