Skip to content

Add links to comments - #2086

Closed
Adam Naji (Bashamega) wants to merge 2 commits into
microsoft:mainfrom
Bashamega:links
Closed

Adam Naji (Bashamega) wants to merge 2 commits into
microsoft:mainfrom
Bashamega:links

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

Originally suggested by me in #2078 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

Comment thread baselines/audioworklet.generated.d.ts Outdated

/**
* The `ReadableStream` interface of the Streams API represents a readable stream of byte data.
* The `ReadableStream` interface of the [Streams API](/en-US/docs/Web/API/Streams_API) represents a readable stream of byte data.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is unrooted

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will fix it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it Jake Bailey (@jakebailey)

@jakebailey

Copy link
Copy Markdown
Member

Is this actually a good idea? It seems like a lot of text, and the docs already include a link.

@Bashamega

Copy link
Copy Markdown
Contributor Author

Is this actually a good idea? It seems like a lot of text, and the docs already include a link.

I think people would benefit from it, maybe Kagami Sascha Rosylight (@saschanaz) has an opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants