Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the shared Codex app-server exits, pending requests can fail while the session event stream stays open. The session manager can retain the dead runtime, leaving turns stuck and later requests reusing it.
Change
Propagate child termination through the client and adapter event stream so the existing session manager can release the runtime and replace it on the next turn. Bound output draining and record child lifecycle diagnostics with lifecycle-specific trace redaction, preserving caller failures, cancellation, and unrelated error visibility.
Scope and approval
This is a fork-local review boundary, not a new submission to
pingdotgg/t3code. Upstream recovery PRs #21759 and #18764 overlap; no upstream maintainer approval or distinct contribution eligibility is claimed.Frozen head:
44ccaab8eae39ad8e006bf0971772ff79ae22b4b. Review baseline:401b01747c1f7b331fb00b573e405a38f646fde8(chore(release): prepare v0.1.3), the source checkout's exact baseline. A dedicated baseline branch keeps this review to the 13 candidate paths and excludes the upstream history missing from forkmain. No source edits, dependency declaration changes, or lockfile changes were made during delivery.Verification
Windows, pinned Node
26.12.1, repository Vite+1.4.0and pnpm12.14.0.vp run check:changedpassed: format, lint, both knip lanes, server GraphQL generation check, all 32 affected package typechecks, and 182 tests across 7 test files. The gate selected 14 test paths. No hosted CI result is implied.KNIP_DISABLE_RAW_TRANSFER=1normal-parser path and the existing Windowsvpspawn adapter; check selection, rules, and exit status were preserved. The successful run was not cached because generated inputs changed during the run; tracked source remained clean.4.2.2measured the changed observability functions at11 / 6 / 1, threshold 15, without suppression; existing whole-file legacy findings are separate.9a9468b8b66bdc53bd55a33af94fffc34f4ae171a79d16a2f465e0ff6bd99f12. Synthetic spawn failure and an owned real child exiting 7 preserved typed caller failure, cancellation, and unrelated errors. Local trace and OTLP JSON serialization checks used in-memory sinks/HTTP, not hosted telemetry.2026-10-27T15:31:22.281Z–16:01:25.866Z(1,803,585 ms), six distinct completed native turns and three manager-owned replacements (idle / active / idle). It used the actual sourceProviderSessionManagerandCodexAdapter, an injected real client factory, and in-memory stores. Runtime receipt SHA256:a10307b144dd167260042c677849826fd56fa42c0bd8bba6b2698311d182e6df. The earlier interrupted duration window is excluded.Current gate transcript:
Still UNKNOWN: installed desktop acceptance, default-factory integration acceptance, hosted CI, actual PostHog delivery, and the original spontaneous Windows exit cause. This PR does not authorize merge, release, installation into the running app, or deployment.
Model and harness: OpenAI Codex for the frozen implementation in T3 Code (exact source model not independently verified); GPT-6 in Codex desktop for local setup, evidence inspection, and PR delivery.